Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update from OpenAPI spec (19 may) #390

Merged
merged 5 commits into from
May 19, 2023
Merged

Conversation

nkvuong
Copy link
Contributor

@nkvuong nkvuong commented May 12, 2023

Changes

  • Updates SDK based on the latest changes from the openapi spec
  • Avoid generating name-to-id mapping if there are more than 1 name fields

Tests

  • make test passing
  • make fmt applied
  • relevant integration tests applied

@codecov-commenter
Copy link

codecov-commenter commented May 12, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.06 ⚠️

Comparison is base (dd7286e) 34.57% compared to head (ab7af0a) 34.51%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #390      +/-   ##
==========================================
- Coverage   34.57%   34.51%   -0.06%     
==========================================
  Files          50       50              
  Lines        3566     3572       +6     
==========================================
  Hits         1233     1233              
- Misses       2220     2226       +6     
  Partials      113      113              
Impacted Files Coverage Δ
openapi/code/entity.go 34.37% <0.00%> (-2.30%) ⬇️
openapi/code/method.go 17.05% <0.00%> (-0.27%) ⬇️
service/compute/api.go 8.39% <ø> (ø)
service/compute/model.go 0.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@nkvuong nkvuong changed the title Refresh sdk based of latest openapi spec (12 may) Refresh sdk based of latest openapi spec (19 may) May 19, 2023
//
// This method is generated by Databricks SDK Code Generator.
func (a *TokensAPI) GetByComment(ctx context.Context, name string) (*PublicTokenInfo, error) {
func (a *TokensAPI) GetByComment(ctx context.Context, name string) (*TokenInfo, error) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this compatible change?

@nfx nfx changed the title Refresh sdk based of latest openapi spec (19 may) Update from OpenAPI spec (19 may) May 19, 2023
@nfx nfx merged commit 9149e34 into databricks:main May 19, 2023
@nkvuong nkvuong deleted the refresh-openapi branch May 19, 2023 13:48
@nfx nfx mentioned this pull request May 22, 2023
nfx added a commit that referenced this pull request May 22, 2023
* Added more usage examples for `go doc` and Go Packages
([#389](#389)).
* Make OAuth work with new CLI
([#394](#394)).
* Update from OpenAPI spec
([#390](#390)).

Dependency updates:

* Bump github.com/stretchr/testify from 1.8.2 to 1.8.3
([#393](#393)).
* Bump google.golang.org/api from 0.122.0 to 0.123.0
([#392](#392)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants