Add SCIM Patch Acceptance Test #540

mgyucht · 2023-06-30T14:28:53Z

Changes

Adds an acceptance test covering SCIM user patch that users can leverage when interacting with the SCIM API.

Tests

make test passing
make fmt applied
relevant integration tests applied

codecov-commenter · 2023-06-30T14:31:28Z

Codecov Report

Patch and project coverage have no change.

Comparison is base (546814a) 18.70% compared to head (e45a6ec) 18.70%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #540   +/-   ##
=======================================
  Coverage   18.70%   18.70%           
=======================================
  Files          85       85           
  Lines        9326     9326           
=======================================
  Hits         1744     1744           
  Misses       7431     7431           
  Partials      151      151

Impacted Files	Coverage Δ
openapi/roll/optimize.go	`0.00% <0.00%> (ø)`
service/iam/model.go	`0.00% <ø> (ø)`

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

nfx · 2023-06-30T15:11:14Z

examples/scim-patch/main.go

@@ -0,0 +1,127 @@
+package main


Use godoc examples to make it discoverable https://go.dev/blog/examples

make doc to preview

nfx · 2023-06-30T15:13:02Z

examples/scim-patch/main.go

+)
+
+func fetchAndPrintUserName(c *databricks.AccountClient, id string) error {
+	user, err := c.Users.GetById(context.Background(), id)


Ctx must always be the first parameters and initialized as much at the top of business logic as possible. Here - in main()

nfx · 2023-06-30T15:13:54Z

examples/scim-patch/main.go

+	// Create a client
+	cfg := databricks.Config{
+		Host: "https://accounts.cloud.databricks.com",
+		// Specify Account ID via the DATABRICKS_ACCOUNT_ID environment variable


Use input util from other examples

nfx · 2023-06-30T15:14:40Z

examples/scim-patch/main.go

+	// Fetch the user
+	err = fetchAndPrintUserName(c, userID)
+	if err != nil {
+		fmt.Printf("Error fetching user: %s\n", err)


Panic here instead.

nfx · 2023-06-30T15:15:33Z

examples/scim-patch/main.go

+	}
+
+	// restore the old name
+	pu = iam.PartialUpdate{


Follow the style of hundreds of other examples and inline the request var

nfx · 2023-07-14T10:16:40Z

internal/scim_test.go

@@ -152,3 +152,37 @@ func TestAccServicePrincipalsOnAWS(t *testing.T) {
 	assert.Equal(t, len(names), len(all))
 	assert.Equal(t, byId.Id, names[byId.DisplayName])
 }
+
+func TestAccUserPatch(t *testing.T) {


this change also needs accompanying example changes. make sure ~/.openapi-codegen.json has the gosdk path and re-run make gen after. then run oac in the python SDK - I'm afraid that PatchSchemaUrnIetfParamsScimApiMessagesPatchop won't get translated.

{ "spec": "...../openapi/all-internal.json", "gosdk": "..../databricks-sdk-go" }

nfx

regen comments

) ## Changes Add SCIM examples for updating a user via the PATCH API at the account level. This PR reruns the OpenAPI generator from databricks/databricks-sdk-go#540. This ensures that enum names are handled correctly in the example optimizer, and it also includes one additional bugfix to enum value parsing causing `URN_IETF_PARAMS_SCIM_API_MESSAGES20_PATCH_OP` to be renamed to `URN_IETF_PARAMS_SCIM_API_MESSAGES_2_0_PATCH_OP`. ## Tests  - [ ] `make test` run locally - [ ] `make fmt` applied - [ ] relevant integration tests applied

First draft

6a295c0

mgyucht force-pushed the fix-scim branch from 80e8af7 to 6a295c0 Compare June 30, 2023 14:31

nfx suggested changes Jun 30, 2023

View reviewed changes

mgyucht added 3 commits July 6, 2023 22:48

Merge branch 'main' into fix-scim

b0848f0

Merge branch 'main' into fix-scim

a94c0de

Rewrite as acceptance test

eb4a08b

mgyucht changed the title ~~[WIP] SCIM Patch Demo~~ Add SCIM Patch Acceptance Test Jul 13, 2023

mgyucht requested review from nfx July 13, 2023 11:02

nfx suggested changes Jul 14, 2023

View reviewed changes

nfx added the do-not-merge label Jul 17, 2023

mgyucht added 2 commits July 18, 2023 09:41

Merge branch 'main' into fix-scim

6608adb

Fix handling of enum value in example optimizer

e45a6ec

mgyucht mentioned this pull request Jul 18, 2023

Updated account-level and workspace-level user management examples databricks/databricks-sdk-py#241

Merged

3 tasks

mgyucht requested a review from nfx July 18, 2023 08:22

nfx approved these changes Jul 18, 2023

View reviewed changes

nfx merged commit 180c7ee into main Jul 18, 2023

nfx deleted the fix-scim branch July 18, 2023 11:41

nfx mentioned this pull request Jul 18, 2023

Release 0.13.0 #555

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add SCIM Patch Acceptance Test #540

Add SCIM Patch Acceptance Test #540

mgyucht commented Jun 30, 2023 •

edited

Loading

codecov-commenter commented Jun 30, 2023 •

edited

Loading

nfx Jun 30, 2023

nfx Jun 30, 2023

nfx Jun 30, 2023

nfx Jun 30, 2023

nfx Jun 30, 2023

nfx Jul 14, 2023

nfx left a comment

Add SCIM Patch Acceptance Test #540

Add SCIM Patch Acceptance Test #540

Conversation

mgyucht commented Jun 30, 2023 • edited Loading

Changes

Tests

codecov-commenter commented Jun 30, 2023 • edited Loading

Codecov Report

nfx Jun 30, 2023

Choose a reason for hiding this comment

nfx Jun 30, 2023

Choose a reason for hiding this comment

nfx Jun 30, 2023

Choose a reason for hiding this comment

nfx Jun 30, 2023

Choose a reason for hiding this comment

nfx Jun 30, 2023

Choose a reason for hiding this comment

nfx Jul 14, 2023

Choose a reason for hiding this comment

nfx left a comment

Choose a reason for hiding this comment

mgyucht commented Jun 30, 2023 •

edited

Loading

codecov-commenter commented Jun 30, 2023 •

edited

Loading