Support x-databricks-path-style overrides at the operation level #562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nfx
reviewed
Jul 26, 2023
|
It's needed for the permissions refactor being done by @Rchakmak. His permissions APIs are all RESTful, but they will be part of services that are marked as RPC style. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #562 +/- ##
==========================================
- Coverage 18.73% 18.73% -0.01%
==========================================
Files 85 85
Lines 9388 9405 +17
==========================================
+ Hits 1759 1762 +3
- Misses 7477 7489 +12
- Partials 152 154 +2
☔ View full report in Codecov by Sentry. |
pietern
approved these changes
Jul 27, 2023
Merged
mgyucht
added a commit
that referenced
this pull request
Jul 27, 2023
mgyucht
added a commit
that referenced
this pull request
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
In order to support multiple styles of request under a single service, we introduce support for overriding x-databricks-path-style at the Operation level. This will allow RPC- and REST-style operations to exist under a single service. To determine the path style for a method, we check for a method-level override, falling back to the service-level setting. If neither is set, the path style is assumed to be "rest".
Tests
Tested by regenerating the Python SDK using a spec I edited by hand to include this extension at the operation level. The generated code was as I expected (using the operation ID to derive name in the Clusters service, which is normally an RPC style service).
make testpassingmake fmtapplied