Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort permissions related methods after everything else #599

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

pietern
Copy link
Contributor

@pietern pietern commented Sep 1, 2023

Changes

Order the primary methods first, followed by the permission methods.
This keeps the docs in a more logical order. Otherwise, the permission
methods would be interspersed with the primary methods.

Tests

Confirmed this works with manual regeneration.

@pietern pietern requested a review from mgyucht September 1, 2023 14:44
@pietern
Copy link
Contributor Author

pietern commented Sep 1, 2023

This makes sense even in the generate code (interfaces etc).

@pietern
Copy link
Contributor Author

pietern commented Sep 1, 2023

Let's hold this until after #598 is merged and applied.

@codecov-commenter
Copy link

codecov-commenter commented Sep 1, 2023

Codecov Report

Attention: 122 lines in your changes are missing coverage. Please review.

Files Coverage Δ
client/client.go 85.77% <100.00%> (+0.87%) ⬆️
config/oauth_visitors.go 81.25% <100.00%> (+0.60%) ⬆️
openapi/model.go 5.19% <ø> (ø)
service/billing/model.go 0.00% <ø> (ø)
service/iam/model.go 0.00% <ø> (ø)
service/jobs/api.go 0.00% <ø> (ø)
service/ml/model.go 0.00% <ø> (ø)
service/pipelines/model.go 0.00% <ø> (ø)
service/provisioning/model.go 0.00% <ø> (ø)
service/sql/api.go 0.00% <ø> (ø)
... and 17 more

📢 Thoughts on this report? Let us know!.

Copy link
Contributor

@mgyucht mgyucht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants