Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update error message assertions #607

Merged
merged 1 commit into from
Sep 6, 2023
Merged

Update error message assertions #607

merged 1 commit into from
Sep 6, 2023

Conversation

pietern
Copy link
Contributor

@pietern pietern commented Sep 6, 2023

Changes

Error messages changed in #592 and got reverted in #604.

This fixes the nightlies.

Tests

  • make test passing
  • make fmt applied
  • relevant integration tests applied

@pietern
Update error message assertions
d6ce6fb 
Error messages changed in #592 and got reverted in #604.

This fixes the nightlies.
@codecov-commenter
Copy link

Codecov Report

Patch has no changes to coverable lines.

📢 Thoughts on this report? Let us know!.

@hectorcast-db
Copy link
Contributor

We reverted it because it caused issue to the customers. What is the status there?

@pietern
Copy link
Contributor Author

pietern commented Sep 6, 2023

The revert was merged in #604. A new release must be made to get it out. And that unblocks the TF bump, AFAIK.

@pietern pietern added this pull request to the merge queue Sep 6, 2023
Merged via the queue into main with commit 2a1d490 Sep 6, 2023
4 checks passed
@pietern pietern deleted the fix-tests branch September 6, 2023 09:56
tanmay-db added a commit that referenced this pull request Sep 6, 2023
@tanmay-db
Release v0.19.1
b4b7d10 
* Handle Azure authentication when WorkspaceResourceID is provided ([#597](#597)).
* Revert error message changes from client.go ([#604](#604)).
* Reuse tokens after first call to Azure CLI ([#605](#605)).
* Update error message assertions ([#607](#607)).
@tanmay-db tanmay-db mentioned this pull request Sep 6, 2023
Merged
tanmay-db added a commit that referenced this pull request Sep 6, 2023
@tanmay-db
Release v0.19.1
cd85f7e 
* Handle Azure authentication when WorkspaceResourceID is provided ([#597](#597)).
* Revert error message changes from client.go ([#604](#604)).
* Reuse tokens after first call to Azure CLI ([#605](#605)).
* Update error message assertions ([#607](#607)).
tanmay-db added a commit that referenced this pull request Sep 6, 2023
@tanmay-db
Release v0.19.1
7b7273e 
* Handle Azure authentication when WorkspaceResourceID is provided ([#597](#597)).
* Revert error message changes from client.go ([#604](#604)).
* Reuse tokens after first call to Azure CLI ([#605](#605)).
* Update error message assertions ([#607](#607)).
tanmay-db added a commit that referenced this pull request Sep 6, 2023
@tanmay-db
Release v0.19.1
793de56 
* Handle Azure authentication when WorkspaceResourceID is provided ([#597](#597)).
* Revert error message changes from client.go ([#604](#604)).
* Reuse tokens after first call to Azure CLI ([#605](#605)).
* Update error message assertions ([#607](#607)).
github-merge-queue bot pushed a commit that referenced this pull request Sep 7, 2023
@tanmay-db
Release v0.19.1 (#608)
ad0cb9e 
* Handled Azure authentication when WorkspaceResourceID is provided
([#597](#597)).
* Reverted error message changes from client.go
([#604](#604)).
* Reused tokens after first call to Azure CLI
([#605](#605)).
* Updated error message assertions
([#607](#607)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hectorcast-db hectorcast-db hectorcast-db approved these changes

@mgyucht mgyucht Awaiting requested review from mgyucht

@kartikgupta-db kartikgupta-db Awaiting requested review from kartikgupta-db

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pietern @codecov-commenter @hectorcast-db