Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ForceSendFields and a custom Marshaller #615

Merged
merged 26 commits into from
Oct 11, 2023
Merged

Add ForceSendFields and a custom Marshaller #615

merged 26 commits into from
Oct 11, 2023

Conversation

hectorcast-db
Copy link
Contributor

@hectorcast-db hectorcast-db commented Sep 13, 2023 •
edited
Loading

Changes

Add ForceSendFields and a custom JSON Marshaller to support adding default Go fields in the API calls.

Tests

  • make test passing
  • make fmt applied
  • relevant integration tests applied

@codecov-commenter
Copy link

codecov-commenter commented Sep 13, 2023 •
edited
Loading

Codecov Report

Attention: 1130 lines in your changes are missing coverage. Please review.

Files Coverage Δ
marshal/reflect_cache.go 100.00% <100.00%> (ø)
marshal/types.go 100.00% <100.00%> (ø)
openapi/code/entity.go 26.88% <0.00%> (-1.53%) ⬇️
marshal/marshal.go 87.95% <87.95%> (ø)
service/billing/model.go 0.00% <0.00%> (ø)
marshal/unmarshal.go 66.66% <66.66%> (ø)
service/provisioning/model.go 0.00% <0.00%> (ø)
service/settings/model.go 0.00% <0.00%> (ø)
service/workspace/model.go 0.00% <0.00%> (ø)
service/iam/model.go 0.00% <0.00%> (ø)
... and 7 more

📢 Thoughts on this report? Let us know!.

@pietern pietern mentioned this pull request Sep 13, 2023
Closed
pietern
pietern reviewed Sep 14, 2023
View reviewed changes
Copy link
Contributor

@pietern pietern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only looked at marshal.go so far.

The package directory is json but the package name is marshal. They should match.

json/marshal.go Outdated Show resolved Hide resolved
json/marshal.go Outdated Show resolved Hide resolved
json/marshal.go Outdated Show resolved Hide resolved
json/marshal.go Outdated Show resolved Hide resolved
json/marshal.go Outdated Show resolved Hide resolved
json/marshal.go Outdated Show resolved Hide resolved
json/marshal.go Outdated Show resolved Hide resolved
json/marshal.go Outdated Show resolved Hide resolved
json/marshal.go Outdated Show resolved Hide resolved
andrewnester
andrewnester reviewed Sep 14, 2023
View reviewed changes
marshal/marshal.go Outdated Show resolved Hide resolved
marshal/marshal.go Show resolved Hide resolved
marshal/marshal.go Outdated Show resolved Hide resolved
nfx
nfx previously requested changes Sep 14, 2023
View reviewed changes
.codegen/model.go.tmpl Outdated Show resolved Hide resolved
.codegen/model.go.tmpl Outdated Show resolved Hide resolved
@hectorcast-db hectorcast-db changed the title Custom marshaller test Add ForceSendFields and a custom Marshaller Sep 18, 2023
mgyucht
mgyucht approved these changes Sep 21, 2023
View reviewed changes
marshal/marshal.go Outdated Show resolved Hide resolved
marshal/marshal.go Outdated Show resolved Hide resolved
marshal/marshal.go Outdated Show resolved Hide resolved
marshal/marshal.go Show resolved Hide resolved
marshal/marshal.go Outdated Show resolved Hide resolved
marshal/unmarshal.go Outdated Show resolved Hide resolved
openapi/code/entity.go Outdated Show resolved Hide resolved
.codegen/model.go.tmpl Outdated Show resolved Hide resolved
marshal/unmarshal.go Outdated Show resolved Hide resolved
marshal/unmarshal.go Outdated Show resolved Hide resolved
pietern
pietern reviewed Sep 22, 2023
View reviewed changes
marshal/marshal.go Show resolved Hide resolved
marshal/marshal.go Outdated Show resolved Hide resolved
marshal/marshal.go Outdated Show resolved Hide resolved
marshal/marshal.go Outdated Show resolved Hide resolved
marshal/marshal.go Outdated Show resolved Hide resolved
marshal/types.go Outdated Show resolved Hide resolved
marshal/unmarshal.go Outdated Show resolved Hide resolved
marshal/unmarshal.go Show resolved Hide resolved
pietern
pietern reviewed Sep 22, 2023
View reviewed changes
marshal/marshal.go Outdated Show resolved Hide resolved
marshal/reflect_cache.go Show resolved Hide resolved
marshal/reflect_cache.go Show resolved Hide resolved
marshal/unmarshal.go Outdated Show resolved Hide resolved
marshal/unmarshal.go Show resolved Hide resolved
pietern
pietern reviewed Sep 25, 2023
View reviewed changes
marshal/marshal.go Show resolved Hide resolved
marshal/marshal.go Show resolved Hide resolved
marshal/reflect_cache.go Show resolved Hide resolved
marshal/reflect_cache.go Outdated Show resolved Hide resolved
marshal/reflect_cache.go Show resolved Hide resolved
marshal/unmarshal.go Outdated Show resolved Hide resolved
marshal/unmarshal.go Outdated Show resolved Hide resolved
pietern
pietern reviewed Sep 25, 2023
View reviewed changes
marshal/reflect_cache.go Show resolved Hide resolved
marshal/unmarshal.go Show resolved Hide resolved
marshal/marshal.go Outdated Show resolved Hide resolved
mgyucht
mgyucht approved these changes Oct 11, 2023
View reviewed changes
Copy link
Contributor

@mgyucht mgyucht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple last points, otherwise LGTM.

.codegen/model.go.tmpl Show resolved Hide resolved
marshal/composite_test.go Outdated Show resolved Hide resolved
marshal/types_test.go Outdated Show resolved Hide resolved
marshal/unmarshal.go Outdated Show resolved Hide resolved
marshal/unmarshal.go Outdated Show resolved Hide resolved
marshal/types_childfs_test.go Outdated Show resolved Hide resolved
marshal/types_test.go Outdated Show resolved Hide resolved
marshal/marshal.go Show resolved Hide resolved
marshal/types_maptointerface_test.go Outdated Show resolved Hide resolved
mgyucht
mgyucht reviewed Oct 11, 2023
View reviewed changes
marshal/marshal.go Outdated Show resolved Hide resolved
@hectorcast-db @mgyucht
Update comment in marshal/marshal.go
baffd4d 
Co-authored-by: Miles Yucht <miles@databricks.com>
@mgyucht mgyucht requested a review from nfx October 11, 2023 11:26
@mgyucht mgyucht dismissed nfx’s stale review October 11, 2023 11:26

Acknowledged but this is still in a good state to merge. We can revisit later if necessary.

@mgyucht mgyucht added this pull request to the merge queue Oct 11, 2023
Merged via the queue into main with commit 39ea322 Oct 11, 2023
4 checks passed
@mgyucht mgyucht deleted the custom-marshaller-test branch October 11, 2023 11:29
pietern added a commit that referenced this pull request Oct 12, 2023
@pietern
Release v0.23.0
4db8826 
Note: this release includes custom JSON marshalling that captures whether or
not a value is set and should be included in the marshalled output, if its
value is equal to Go's zero value (i.e. `0` for an int field).

* Add ForceSendFields and a custom marshaller ([#615](#615)).
* Support text/plain response as streaming request body ([#638](#638)).
* Added log statement if OIDC response is non 200 ([#644](#644)).

API Changes:

 * Changed `Download` method for [a.BillableUsage](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/billing#BillableUsageAPI) account-level service to start returning [billing.DownloadResponse](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/billing#DownloadResponse).
 * Added [billing.DownloadResponse](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/billing#DownloadResponse).
 * Changed `Delete` method for [a.AccountStorageCredentials](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/catalog#AccountStorageCredentialsAPI) account-level service with new required argument order.
 * Changed `Get` method for [a.AccountStorageCredentials](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/catalog#AccountStorageCredentialsAPI) account-level service with new required argument order.
 * Changed `Update` method for [a.AccountStorageCredentials](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/catalog#AccountStorageCredentialsAPI) account-level service with new required argument order.
 * Added `GetBindings` method for [w.WorkspaceBindings](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/catalog#WorkspaceBindingsAPI) workspace-level service.
 * Added `UpdateBindings` method for [w.WorkspaceBindings](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/catalog#WorkspaceBindingsAPI) workspace-level service.
 * Removed `Name` field for [catalog.AccountsUpdateStorageCredential](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/catalog#AccountsUpdateStorageCredential).
 * Added `StorageCredentialName` field for [catalog.AccountsUpdateStorageCredential](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/catalog#AccountsUpdateStorageCredential).
 * Removed `Name` field for [catalog.DeleteAccountStorageCredentialRequest](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/catalog#DeleteAccountStorageCredentialRequest).
 * Added `StorageCredentialName` field for [catalog.DeleteAccountStorageCredentialRequest](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/catalog#DeleteAccountStorageCredentialRequest).
 * Removed `Name` field for [catalog.GetAccountStorageCredentialRequest](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/catalog#GetAccountStorageCredentialRequest).
 * Added `StorageCredentialName` field for [catalog.GetAccountStorageCredentialRequest](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/catalog#GetAccountStorageCredentialRequest).
 * Added `Owner` field for [catalog.UpdateConnection](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/catalog#UpdateConnection).
 * Added [catalog.GetBindingsRequest](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/catalog#GetBindingsRequest).
 * Added [catalog.UpdateWorkspaceBindingsParameters](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/catalog#UpdateWorkspaceBindingsParameters).
 * Added [catalog.WorkspaceBinding](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/catalog#WorkspaceBinding).
 * Added [catalog.WorkspaceBindingBindingType](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/catalog#WorkspaceBindingBindingType).
 * Added [catalog.WorkspaceBindingsResponse](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/catalog#WorkspaceBindingsResponse).
 * Added `Spec` field for [compute.ClusterDetails](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/compute#ClusterDetails).
 * Added `ApplyPolicyDefaultValues` field for [compute.ClusterSpec](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/compute#ClusterSpec).
 * Removed `AwsAttributes` field for [compute.EditInstancePool](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/compute#EditInstancePool).
 * Removed `AzureAttributes` field for [compute.EditInstancePool](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/compute#EditInstancePool).
 * Removed `DiskSpec` field for [compute.EditInstancePool](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/compute#EditInstancePool).
 * Removed `EnableElasticDisk` field for [compute.EditInstancePool](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/compute#EditInstancePool).
 * Removed `GcpAttributes` field for [compute.EditInstancePool](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/compute#EditInstancePool).
 * Removed `PreloadedDockerImages` field for [compute.EditInstancePool](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/compute#EditInstancePool).
 * Removed `PreloadedSparkVersions` field for [compute.EditInstancePool](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/compute#EditInstancePool).
 * Added `Deployment` field for [jobs.CreateJob](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#CreateJob).
 * Added `UiState` field for [jobs.CreateJob](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#CreateJob).
 * Added `Deployment` field for [jobs.JobSettings](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#JobSettings).
 * Added `UiState` field for [jobs.JobSettings](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#JobSettings).
 * Removed `ConditionTask` field for [jobs.RunOutput](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#RunOutput).
 * Added `WebhookNotifications` field for [jobs.Task](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#Task).
 * Added [jobs.CreateJobUiState](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#CreateJobUiState).
 * Added [jobs.JobDeployment](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#JobDeployment).
 * Added [jobs.JobDeploymentKind](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#JobDeploymentKind).
 * Added [jobs.JobSettingsUiState](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#JobSettingsUiState).
 * Added `WorkloadType` field for [serving.ServedModelInput](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/serving#ServedModelInput).
 * Added `WorkloadType` field for [serving.ServedModelOutput](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/serving#ServedModelOutput).
 * Removed [a.AccountNetworkPolicy](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/settings#AccountNetworkPolicyAPI) account-level service.
 * Changed `List` method for [w.IpAccessLists](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/settings#IpAccessListsAPI) workspace-level service to return [settings.ListIpAccessListResponse](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/settings#ListIpAccessListResponse).
 * Removed [settings.AccountNetworkPolicyMessage](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/settings#AccountNetworkPolicyMessage).
 * Removed [settings.DeleteAccountNetworkPolicyRequest](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/settings#DeleteAccountNetworkPolicyRequest).
 * Removed [settings.DeleteAccountNetworkPolicyResponse](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/settings#DeleteAccountNetworkPolicyResponse).
 * Removed `IpAccessLists` field for [settings.GetIpAccessListResponse](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/settings#GetIpAccessListResponse).
 * Added `IpAccessList` field for [settings.GetIpAccessListResponse](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/settings#GetIpAccessListResponse).
 * Removed [settings.ReadAccountNetworkPolicyRequest](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/settings#ReadAccountNetworkPolicyRequest).
 * Removed [settings.UpdateAccountNetworkPolicyRequest](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/settings#UpdateAccountNetworkPolicyRequest).
 * Added [settings.ListIpAccessListResponse](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/settings#ListIpAccessListResponse).

OpenAPI SHA: 493a76554afd3afdd15dc858773d01643f80352a, Date: 2023-10-12

Dependency updates:

 * Bump golang.org/x/mod from 0.12.0 to 0.13.0 ([#639](#639)).
 * Bump google.golang.org/api from 0.140.0 to 0.146.0 ([#643](#643)).
 * Bump golang.org/x/net from 0.15.0 to 0.17.0 ([#646](#646)).
 * Bump golang.org/x/oauth2 from 0.12.0 to 0.13.0 ([#642](#642)).
 * Bump golang.org/x/net from 0.8.0 to 0.17.0 in /examples/zerolog ([#647](#647)).
 * Bump golang.org/x/net from 0.8.0 to 0.17.0 in /examples/slog ([#648](#648)).
@pietern pietern mentioned this pull request Oct 12, 2023
Merged
github-merge-queue bot pushed a commit that referenced this pull request Oct 12, 2023
@pietern
Release v0.23.0 (#652)
691dcd7 
Note: this release includes custom JSON marshalling that captures
whether or
not a value is set and should be included in the marshalled output, if
its
value is equal to Go's zero value (i.e. `0` for an int field).

* Add ForceSendFields and a custom marshaller
([#615](#615)).
* Support text/plain response as streaming request body
([#638](#638)).
* Added log statement if OIDC response is non 200
([#644](#644)).

API Changes:

* Changed `Download` method for
[a.BillableUsage](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/billing#BillableUsageAPI)
account-level service to start returning
[billing.DownloadResponse](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/billing#DownloadResponse).
* Added
[billing.DownloadResponse](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/billing#DownloadResponse).
* Changed `Delete` method for
[a.AccountStorageCredentials](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/catalog#AccountStorageCredentialsAPI)
account-level service with new required argument order.
* Changed `Get` method for
[a.AccountStorageCredentials](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/catalog#AccountStorageCredentialsAPI)
account-level service with new required argument order.
* Changed `Update` method for
[a.AccountStorageCredentials](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/catalog#AccountStorageCredentialsAPI)
account-level service with new required argument order.
* Added `GetBindings` method for
[w.WorkspaceBindings](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/catalog#WorkspaceBindingsAPI)
workspace-level service.
* Added `UpdateBindings` method for
[w.WorkspaceBindings](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/catalog#WorkspaceBindingsAPI)
workspace-level service.
* Removed `Name` field for
[catalog.AccountsUpdateStorageCredential](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/catalog#AccountsUpdateStorageCredential).
* Added `StorageCredentialName` field for
[catalog.AccountsUpdateStorageCredential](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/catalog#AccountsUpdateStorageCredential).
* Removed `Name` field for
[catalog.DeleteAccountStorageCredentialRequest](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/catalog#DeleteAccountStorageCredentialRequest).
* Added `StorageCredentialName` field for
[catalog.DeleteAccountStorageCredentialRequest](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/catalog#DeleteAccountStorageCredentialRequest).
* Removed `Name` field for
[catalog.GetAccountStorageCredentialRequest](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/catalog#GetAccountStorageCredentialRequest).
* Added `StorageCredentialName` field for
[catalog.GetAccountStorageCredentialRequest](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/catalog#GetAccountStorageCredentialRequest).
* Added `Owner` field for
[catalog.UpdateConnection](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/catalog#UpdateConnection).
* Added
[catalog.GetBindingsRequest](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/catalog#GetBindingsRequest).
* Added
[catalog.UpdateWorkspaceBindingsParameters](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/catalog#UpdateWorkspaceBindingsParameters).
* Added
[catalog.WorkspaceBinding](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/catalog#WorkspaceBinding).
* Added
[catalog.WorkspaceBindingBindingType](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/catalog#WorkspaceBindingBindingType).
* Added
[catalog.WorkspaceBindingsResponse](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/catalog#WorkspaceBindingsResponse).
* Added `Spec` field for
[compute.ClusterDetails](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/compute#ClusterDetails).
* Added `ApplyPolicyDefaultValues` field for
[compute.ClusterSpec](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/compute#ClusterSpec).
* Removed `AwsAttributes` field for
[compute.EditInstancePool](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/compute#EditInstancePool).
* Removed `AzureAttributes` field for
[compute.EditInstancePool](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/compute#EditInstancePool).
* Removed `DiskSpec` field for
[compute.EditInstancePool](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/compute#EditInstancePool).
* Removed `EnableElasticDisk` field for
[compute.EditInstancePool](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/compute#EditInstancePool).
* Removed `GcpAttributes` field for
[compute.EditInstancePool](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/compute#EditInstancePool).
* Removed `PreloadedDockerImages` field for
[compute.EditInstancePool](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/compute#EditInstancePool).
* Removed `PreloadedSparkVersions` field for
[compute.EditInstancePool](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/compute#EditInstancePool).
* Added `Deployment` field for
[jobs.CreateJob](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#CreateJob).
* Added `UiState` field for
[jobs.CreateJob](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#CreateJob).
* Added `Deployment` field for
[jobs.JobSettings](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#JobSettings).
* Added `UiState` field for
[jobs.JobSettings](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#JobSettings).
* Removed `ConditionTask` field for
[jobs.RunOutput](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#RunOutput).
* Added `WebhookNotifications` field for
[jobs.Task](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#Task).
* Added
[jobs.CreateJobUiState](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#CreateJobUiState).
* Added
[jobs.JobDeployment](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#JobDeployment).
* Added
[jobs.JobDeploymentKind](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#JobDeploymentKind).
* Added
[jobs.JobSettingsUiState](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#JobSettingsUiState).
* Added `WorkloadType` field for
[serving.ServedModelInput](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/serving#ServedModelInput).
* Added `WorkloadType` field for
[serving.ServedModelOutput](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/serving#ServedModelOutput).
* Removed
[a.AccountNetworkPolicy](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/settings#AccountNetworkPolicyAPI)
account-level service.
* Changed `List` method for
[w.IpAccessLists](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/settings#IpAccessListsAPI)
workspace-level service to return
[settings.ListIpAccessListResponse](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/settings#ListIpAccessListResponse).
* Removed
[settings.AccountNetworkPolicyMessage](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/settings#AccountNetworkPolicyMessage).
* Removed
[settings.DeleteAccountNetworkPolicyRequest](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/settings#DeleteAccountNetworkPolicyRequest).
* Removed
[settings.DeleteAccountNetworkPolicyResponse](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/settings#DeleteAccountNetworkPolicyResponse).
* Removed `IpAccessLists` field for
[settings.GetIpAccessListResponse](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/settings#GetIpAccessListResponse).
* Added `IpAccessList` field for
[settings.GetIpAccessListResponse](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/settings#GetIpAccessListResponse).
* Removed
[settings.ReadAccountNetworkPolicyRequest](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/settings#ReadAccountNetworkPolicyRequest).
* Removed
[settings.UpdateAccountNetworkPolicyRequest](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/settings#UpdateAccountNetworkPolicyRequest).
* Added
[settings.ListIpAccessListResponse](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/settings#ListIpAccessListResponse).

OpenAPI SHA: 493a76554afd3afdd15dc858773d01643f80352a, Date: 2023-10-12

Dependency updates:

* Bump golang.org/x/mod from 0.12.0 to 0.13.0
([#639](#639)).
* Bump google.golang.org/api from 0.140.0 to 0.146.0
([#643](#643)).
* Bump golang.org/x/net from 0.15.0 to 0.17.0
([#646](#646)).
* Bump golang.org/x/oauth2 from 0.12.0 to 0.13.0
([#642](#642)).
* Bump golang.org/x/net from 0.8.0 to 0.17.0 in /examples/zerolog
([#647](#647)).
* Bump golang.org/x/net from 0.8.0 to 0.17.0 in /examples/slog
([#648](#648)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewnester andrewnester andrewnester left review comments

@mgyucht mgyucht mgyucht approved these changes

@pietern pietern pietern left review comments

@nfx nfx Awaiting requested review from nfx

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@hectorcast-db @codecov-commenter @pietern @nfx @mgyucht @andrewnester