Wrap url.Error in APIError #722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #722 +/- ##
==========================================
- Coverage 16.85% 16.81% -0.05%
==========================================
Files 103 103
Lines 14109 14116 +7
==========================================
- Hits 2378 2373 -5
- Misses 11525 11535 +10
- Partials 206 208 +2 ☔ View full report in Codecov by Sentry. |
pietern
reviewed
Nov 30, 2023
mgyucht
force-pushed
the
wrap-url-Error-as-before
branch
from
870eac1
to
d38b784
Compare
pietern
reviewed
Nov 30, 2023
| @@ -65,16 +65,6 @@ func New(cfg *config.Config) (*DatabricksClient, error) { | |||
| }, | |||
| TransientErrors: []string{ | |||
| "REQUEST_LIMIT_EXCEEDED", // This is temporary workaround for SCIM API returning 500. Remove when it's fixed | |||
There was a problem hiding this comment.
Looking at this sole example remaining, the field could be removed and folded into ErrorRetriable as well. In this case in the set of transient errors in apierr because it is SCIM related (can be another PR).
There was a problem hiding this comment.
Yeah. I will do that in another PR. I guess this is slightly more generic since it doesn't assume a specific structure of the response body, but I think it would still be OK to move to APIError.
pietern
approved these changes
Nov 30, 2023
mgyucht
added a commit
that referenced
this pull request
Nov 30, 2023
Minor changes: * Support overriding DatabricksEnvironment ([#723](#723)). * Detect `Accept` header in `httpclient.WithResponseUnmarshal` ([#710](#710)). * Detect `Content-Type` header in `newRequestBody` for `httpclient` ([#711](#711)). Bug fixes: * Retry request on `REQUEST_LIMIT_EXCEEDED` error returned by the SCIM API ([#721](#721)). * Match retry logic of pre-refactor SDK ([#722](#722)).
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 30, 2023
Minor changes: * Support overriding DatabricksEnvironment ([#723](#723)). * Detect `Accept` header in `httpclient.WithResponseUnmarshal` ([#710](#710)). * Detect `Content-Type` header in `newRequestBody` for `httpclient` ([#711](#711)). Bug fixes: * Retry request on `REQUEST_LIMIT_EXCEEDED` error returned by the SCIM API ([#721](#721)). * Match retry logic of pre-refactor SDK ([#722](#722)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
b0f3c83 introduced a regression in the handling of errors returned from HttpClient.Do. Previously, only some errors returned by Client.Do() were retried; now, all are retried. This PR adds default error handling logic in httpclient for errors returned by Client.Do() matching the previous behavior. As part of this, we remove the duplicated transient error messages between apierr and the default client.
Tests
make testpassingmake fmtapplied