Added config.NewAzureCliTokenSource and config.NewAzureMsiTokenSource constructors
#727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rce` helpers This PR exposes Azure CLI and Azure MSI token sources, that can be used externally to authenticate to services like Azure Resource Manager and Microsoft Graph, but still staying within the same testing ecosystem and without any extra dependences.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #727 +/- ##
=======================================
Coverage 17.57% 17.58%
=======================================
Files 103 103
Lines 14188 14191 +3
=======================================
+ Hits 2494 2495 +1
- Misses 11489 11491 +2
Partials 205 205 ☔ View full report in Codecov by Sentry. |
mgyucht
approved these changes
Dec 4, 2023
mgyucht
added a commit
that referenced
this pull request
Dec 7, 2023
This is a bugfix release, including a fix correcting issues with OAuth flows, due to a bug with the propagation of the response status in `httpclient`'s `RoundTrip()` implementation. This fixes the `failed during request visitor: token: oauth2: cannot fetch token: Response: {...}` error.
All fixes:
* Migrate Azure MSI & Metadata Service token sources to `httpclient` and add 100% test coverage ([#709](#709)).
* Added `config.NewAzureCliTokenSource` and `config.NewAzureMsiTokenSource` constructors ([#727](#727)).
* Use per-config refresh context for OAuth tokens ([#728](#728)).
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 7, 2023
This is a bugfix release, including a fix correcting issues with OAuth
flows, due to a bug with the propagation of the response status in
`httpclient`'s `RoundTrip()` implementation. This fixes the `failed
during request visitor: token: oauth2: cannot fetch token: Response:
{...}` error.
All fixes:
* Migrate Azure MSI & Metadata Service token sources to `httpclient` and
add 100% test coverage
([#709](#709)).
* Added `config.NewAzureCliTokenSource` and
`config.NewAzureMsiTokenSource` constructors
([#727](#727)).
* Use per-config refresh context for OAuth tokens
([#728](#728)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR exposes Azure CLI and Azure MSI token sources, that can be used externally to authenticate to services like Azure Resource Manager and Microsoft Graph, but still staying within the same testing ecosystem and without any extra dependencies.
Tests
make testpassingmake fmtapplied