New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix integration test for TestMwsAccWorkspaces #763

Merged

mgyucht merged 1 commit into main from fix-mws-acc-workspaces-integration-test

Jan 10, 2024

Contributor

mgyucht commented Jan 9, 2024 •

edited

Loading

Changes

Small fix for the integration test for TestMwsAccWorkspaces:

we need to register the credential cleanup before the workspace cleanup so that we delete the credential after the workspace is deleted.
we are deleting the same credential twice due to a typo. Need to delete both credentials.

Tests

make test passing
make fmt applied
relevant integration tests applied


          Fix integration test for TestMwsAccWorkspaces

c3fec68

mgyucht requested a review from tanmay-db

January 9, 2024 15:34

mgyucht enabled auto-merge

January 10, 2024 08:48

mgyucht requested a review from shreyas-goenka

January 10, 2024 08:49

shreyas-goenka approved these changes

View reviewed changes

mgyucht added this pull request to the merge queue

Merged via the queue into main with commit f80a00d

4 checks passed

mgyucht deleted the fix-mws-acc-workspaces-integration-test branch

January 10, 2024 10:14

tanmay-db mentioned this pull request

Release v0.29.0 #761

Merged

github-merge-queue bot pushed a commit that referenced this pull request


          Release v0.29.0 (#761)

959a8fd

* Extract API interfaces for all services and generate mock clients
([#740](#740)).
* Handle empty response for errors
([#756](#756)).
* Update SDK to OpenAPI spec + Fix tests
([#755](#755)).
* Add utility to retry on specific errors
([#757](#757)).
* Integration test fixes for TestMwsAccWorkspaces
([#763](#763)) and
TestMwsAccUsageDownload
([#764](#764)).

Note: This release contains breaking changes, please see below.

API Changes:

* [Breaking] Changed `List` method for
[w.ExternalLocations](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/catalog#ExternalLocationsAPI)
workspace-level service to require request of
[catalog.ListExternalLocationsRequest](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/catalog#ListExternalLocationsRequest),
[w.StorageCredentials](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/catalog#StorageCredentialsAPI)
workspace-level service to require request of
[catalog.ListStorageCredentialsRequest](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/catalog#ListStorageCredentialsRequest)
and
[w.Tokens](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/settings#TokensAPI)
workspace-level service to return
[settings.ListPublicTokensResponse](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/settings#ListPublicTokensResponse).
* Added `NextPageToken` field for
[catalog.ListExternalLocationsResponse](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/catalog#ListExternalLocationsResponse),
[catalog.ListFunctionsResponse](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/catalog#ListFunctionsResponse),
[catalog.ListSchemasResponse](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/catalog#ListSchemasResponse)
and
[catalog.ListStorageCredentialsResponse](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/catalog#ListStorageCredentialsResponse).
* Added `MaxResults` field for
[catalog.ListFunctionsRequest](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/catalog#ListFunctionsRequest)
and
[catalog.ListSchemasRequest](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/catalog#ListSchemasRequest).
* Added `PageToken` field for
[catalog.ListFunctionsRequest](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/catalog#ListFunctionsRequest)
and
[catalog.ListSchemasRequest](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/catalog#ListSchemasRequest).
* Added `OmitColumns` and `OmitProperties` field for
[catalog.ListTablesRequest](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/catalog#ListTablesRequest).
* Added
[catalog.ListExternalLocationsRequest](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/catalog#ListExternalLocationsRequest).
* Added
[catalog.ListStorageCredentialsRequest](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/catalog#ListStorageCredentialsRequest).
* Added
[settings.ListPublicTokensResponse](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/settings#ListPublicTokensResponse).
* Added
[dashboards](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/dashboards)
package.
* Added
[vectorsearch](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/vectorsearch)
package.

OpenAPI SHA: a7a9dc025bb80303e676bf3708942c6aa06689f1, Date: 2024-01-04
Dependency updates:

* Bump google.golang.org/api from 0.153.0 to 0.154.0
([#741](#741)).
* Bump golang.org/x/crypto from 0.14.0 to 0.17.0 in /examples/slog
([#747](#747)) and
/examples/zerolog
([#748](#748)).
* Bump golang.org/x/crypto from 0.16.0 to 0.17.0
([#749](#749)).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet