Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added more error messages for retriable errors (timeouts, etc.) #963

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

alexott
Copy link
Contributor

@alexott alexott commented Jul 4, 2024

These are necessary to handle a problem with timeouts in permissions fetching

Changes

Tests

  • make test passing
  • make fmt applied
  • relevant integration tests applied

Copy link
Contributor

@mgyucht mgyucht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change seems OK but this is an autogenerated file. You just need to update the source of truth.

@alexott alexott force-pushed the more-retriable-errors branch from 909ef09 to eabddfc Compare July 5, 2024 09:45
@mgyucht mgyucht enabled auto-merge July 8, 2024 07:09
auto-merge was automatically disabled July 8, 2024 08:03

Head branch was pushed to by a user without write access

@alexott alexott force-pushed the more-retriable-errors branch from eabddfc to b007810 Compare July 8, 2024 08:03
@alexott alexott force-pushed the more-retriable-errors branch from b007810 to cfecafd Compare July 8, 2024 11:52
These are necessary to handle a problem with timeouts in permissions fetching

Signed-off-by: Alex Ott <alexey.ott@databricks.com>
@alexott alexott force-pushed the more-retriable-errors branch from cfecafd to f9067f2 Compare July 8, 2024 11:55
@mgyucht mgyucht enabled auto-merge July 8, 2024 11:56
@mgyucht mgyucht added this pull request to the merge queue Jul 8, 2024
Merged via the queue into databricks:main with commit c67dc8a Jul 8, 2024
5 checks passed
tanmay-db added a commit that referenced this pull request Jul 8, 2024
### Internal Changes

 * Improve Changelog by grouping changes ([#962](#962)).

### Other Changes

 * Add ChangelogConfig to Generator struct ([#967](#967)).
 * Add DataPlane API Support ([#936](#936)).
 * Add a credentials provider for Github Azure OIDC ([#965](#965)).
 * Added more error messages for retriable errors (timeouts, etc.) ([#963](#963)).
 * Parse API Error messages with `int` error codes ([#960](#960)).
@tanmay-db tanmay-db mentioned this pull request Jul 8, 2024
github-merge-queue bot pushed a commit that referenced this pull request Jul 8, 2024
## 0.43.1

### Major Changes and Improvements:
* Add a credentials provider for Github Azure OIDC
([#965](#965)).
* Add DataPlane API Support
([#936](#936)).
* Added more error messages for retriable errors (timeouts, etc.)
([#963](#963)).

### Internal Changes
* Add ChangelogConfig to Generator struct
([#967](#967)).
* Improve Changelog by grouping changes
([#962](#962)).
* Parse API Error messages with `int` error codes
([#960](#960)).
@alexott alexott deleted the more-retriable-errors branch September 10, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants