Support head operations #232

hectorcast-db · 2024-02-15T08:37:42Z

Changes

Support head operations

Tests

Generated SDK and run Files integration tests.

mgyucht

Overall, looking good. Let's make sure there is at least 1 integration test to cover this case before we merge, if possible.

mgyucht · 2024-02-19T08:21:26Z

databricks-sdk-java/src/main/java/com/databricks/sdk/support/Header.java

+
+@Target({ElementType.FIELD})
+@Retention(RetentionPolicy.RUNTIME)
+public @interface Header {


Can you add a doccomment here?

mgyucht · 2024-02-19T08:22:48Z

databricks-sdk-java/src/main/java/com/databricks/sdk/core/ApiClient.java

+    try {
+      object = target.getDeclaredConstructor().newInstance();
+    } catch (Exception e) {
+      throw new IOException("Unable to initialize an instance of type " + target.getName());


We should throw only DatabricksException here

mgyucht · 2024-02-19T08:26:36Z

databricks-sdk-java/src/main/java/com/databricks/sdk/core/ApiClient.java

+        } else {
+          LOG.warn("Unsupported header type: " + field.getType());
+        }
+        field.setAccessible(false);


Move this from here & catch case to finally

mgyucht · 2024-02-19T08:29:29Z

databricks-sdk-java/src/test/java/com/databricks/sdk/integration/FilesIT.java

@@ -44,7 +44,10 @@ private void writeFileAndReadFileInner(

    // Write the file to DBFS.
    workspace.files().upload(fileName, inputStream);
-
+    // TODO: Enable after SDK generated


Reminder to uncomment this

mgyucht

Approved (though we'll test in a follow-up PR).

Internal Changes: * Support head operations ([#232](#232)). API Changes: * Changed `delete()` method for `workspaceClient.connections()` service with new required argument order. * Changed `get()` method for `workspaceClient.connections()` service with new required argument order. * Changed `update()` method for `workspaceClient.connections()` service with new required argument order. * Changed `update()` method for `workspaceClient.lakehouseMonitors()` service with new required argument order. * Changed `delete()` method for `workspaceClient.volumes()` service with new required argument order. * Changed `read()` method for `workspaceClient.volumes()` service with new required argument order. * Changed `update()` method for `workspaceClient.volumes()` service with new required argument order. * Added `workspaceClient.onlineTables()` service. * Removed `nameArg` field for `com.databricks.sdk.service.catalog.DeleteConnectionRequest`. * Added `name` field for `com.databricks.sdk.service.catalog.DeleteConnectionRequest`. * Removed `fullNameArg` field for `com.databricks.sdk.service.catalog.DeleteVolumeRequest`. * Added `name` field for `com.databricks.sdk.service.catalog.DeleteVolumeRequest`. * Removed `nameArg` field for `com.databricks.sdk.service.catalog.GetConnectionRequest`. * Added `name` field for `com.databricks.sdk.service.catalog.GetConnectionRequest`. * Added `maxResults` field for `com.databricks.sdk.service.catalog.ListVolumesRequest`. * Added `pageToken` field for `com.databricks.sdk.service.catalog.ListVolumesRequest`. * Added `nextPageToken` field for `com.databricks.sdk.service.catalog.ListVolumesResponseContent`. * Removed `fullNameArg` field for `com.databricks.sdk.service.catalog.ReadVolumeRequest`. * Added `name` field for `com.databricks.sdk.service.catalog.ReadVolumeRequest`. * Removed `nameArg` field for `com.databricks.sdk.service.catalog.UpdateConnection`. * Added `name` field for `com.databricks.sdk.service.catalog.UpdateConnection`. * Removed `assetsDir` field for `com.databricks.sdk.service.catalog.UpdateMonitor`. * Removed `fullNameArg` field for `com.databricks.sdk.service.catalog.UpdateVolumeRequestContent`. * Added `name` field for `com.databricks.sdk.service.catalog.UpdateVolumeRequestContent`. * Added `com.databricks.sdk.service.catalog.ContinuousUpdateStatus` class. * Added `com.databricks.sdk.service.catalog.DeleteOnlineTableRequest` class. * Added `com.databricks.sdk.service.catalog.FailedStatus` class. * Added `com.databricks.sdk.service.catalog.GetOnlineTableRequest` class. * Added `com.databricks.sdk.service.catalog.OnlineTable` class. * Added `com.databricks.sdk.service.catalog.OnlineTableSpec` class. * Added `com.databricks.sdk.service.catalog.OnlineTableState` class. * Added `com.databricks.sdk.service.catalog.OnlineTableStatus` class. * Added `com.databricks.sdk.service.catalog.PipelineProgress` class. * Added `com.databricks.sdk.service.catalog.ProvisioningStatus` class. * Added `com.databricks.sdk.service.catalog.TriggeredUpdateStatus` class. * Added `com.databricks.sdk.service.catalog.ViewData` class. * Added `getDirectoryMetadata()` method for `workspaceClient.files()` service. * Added `getMetadata()` method for `workspaceClient.files()` service. * Added `contentLength` field for `com.databricks.sdk.service.files.DownloadResponse`. * Added `contentType` field for `com.databricks.sdk.service.files.DownloadResponse`. * Added `lastModified` field for `com.databricks.sdk.service.files.DownloadResponse`. * Added `com.databricks.sdk.service.files.FileSize` class. * Added `com.databricks.sdk.service.files.GetDirectoryMetadataRequest` class. * Added `com.databricks.sdk.service.files.GetMetadataRequest` class. * Added `com.databricks.sdk.service.files.GetMetadataResponse` class. * Added `com.databricks.sdk.service.files.LastModifiedHttpDate` class. * Removed `triggerHistory` field for `com.databricks.sdk.service.jobs.Job`. * Removed `com.databricks.sdk.service.jobs.TriggerEvaluation` class. * Removed `com.databricks.sdk.service.jobs.TriggerHistory` class. * Added `table` field for `com.databricks.sdk.service.jobs.TriggerSettings`. * Added `com.databricks.sdk.service.jobs.Condition` class. * Added `com.databricks.sdk.service.jobs.TableTriggerConfiguration` class. * Removed `config` field for `com.databricks.sdk.service.serving.ExternalModel`. * Added `ai21labsConfig` field for `com.databricks.sdk.service.serving.ExternalModel`. * Added `anthropicConfig` field for `com.databricks.sdk.service.serving.ExternalModel`. * Added `awsBedrockConfig` field for `com.databricks.sdk.service.serving.ExternalModel`. * Added `cohereConfig` field for `com.databricks.sdk.service.serving.ExternalModel`. * Added `databricksModelServingConfig` field for `com.databricks.sdk.service.serving.ExternalModel`. * Added `openaiConfig` field for `com.databricks.sdk.service.serving.ExternalModel`. * Added `palmConfig` field for `com.databricks.sdk.service.serving.ExternalModel`. * Removed `com.databricks.sdk.service.serving.ExternalModelConfig` class. * Added `maxProvisionedThroughput` field for `com.databricks.sdk.service.serving.ServedEntityInput`. * Added `minProvisionedThroughput` field for `com.databricks.sdk.service.serving.ServedEntityInput`. * Added `maxProvisionedThroughput` field for `com.databricks.sdk.service.serving.ServedEntityOutput`. * Added `minProvisionedThroughput` field for `com.databricks.sdk.service.serving.ServedEntityOutput`. * Changed `delete()` method for `workspaceClient.cleanRooms()` service with new required argument order. * Changed `get()` method for `workspaceClient.cleanRooms()` service with new required argument order. * Changed `update()` method for `workspaceClient.cleanRooms()` service with new required argument order. * Removed `nameArg` field for `com.databricks.sdk.service.sharing.DeleteCleanRoomRequest`. * Added `name` field for `com.databricks.sdk.service.sharing.DeleteCleanRoomRequest`. * Removed `nameArg` field for `com.databricks.sdk.service.sharing.GetCleanRoomRequest`. * Added `name` field for `com.databricks.sdk.service.sharing.GetCleanRoomRequest`. * Removed `nameArg` field for `com.databricks.sdk.service.sharing.UpdateCleanRoom`. * Added `name` field for `com.databricks.sdk.service.sharing.UpdateCleanRoom`. * Added `enumOptions` field for `com.databricks.sdk.service.sql.Parameter`. * Added `multiValuesOptions` field for `com.databricks.sdk.service.sql.Parameter`. * Added `queryId` field for `com.databricks.sdk.service.sql.Parameter`. * Added `com.databricks.sdk.service.sql.MultiValuesOptions` class. OpenAPI SHA: cdd76a98a4fca7008572b3a94427566dd286c63b, Date: 2024-02-19

hectorcast-db added 7 commits February 13, 2024 12:50

Support HEAD operations

730ba27

WIP

54deeea

Fixes

ebed772

Remove unwanted changes

ff3fe46

More updates

82c2301

Fix reflection

6e957b4

Fixes

4591f43

hectorcast-db requested review from edwardfeng-db and tanmay-db February 15, 2024 08:37

hectorcast-db added 3 commits February 15, 2024 09:39

FMT

c78e27e

Undo fmt

631f383

Remove headers for collections

f6008b3

edwardfeng-db approved these changes Feb 15, 2024

View reviewed changes

hectorcast-db added 3 commits February 15, 2024 17:18

Remove unused code

8d78f9f

Sort method

1d6a4b5

Regenerate

b0c8e34

mgyucht reviewed Feb 19, 2024

View reviewed changes

mgyucht approved these changes Feb 19, 2024

View reviewed changes

FIxes

15d73c7

hectorcast-db added this pull request to the merge queue Feb 19, 2024

Merged via the queue into main with commit a583719 Feb 19, 2024
9 checks passed

hectorcast-db deleted the support-head-operations branch February 19, 2024 11:02

hectorcast-db mentioned this pull request Feb 19, 2024

Release v0.19.0 #234

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support head operations #232

Support head operations #232

hectorcast-db commented Feb 15, 2024

mgyucht left a comment

mgyucht Feb 19, 2024

mgyucht Feb 19, 2024

mgyucht Feb 19, 2024

mgyucht Feb 19, 2024

mgyucht left a comment

Support head operations #232

Support head operations #232

Conversation

hectorcast-db commented Feb 15, 2024

Changes

Tests

mgyucht left a comment

Choose a reason for hiding this comment

mgyucht Feb 19, 2024

Choose a reason for hiding this comment

mgyucht Feb 19, 2024

Choose a reason for hiding this comment

mgyucht Feb 19, 2024

Choose a reason for hiding this comment

mgyucht Feb 19, 2024

Choose a reason for hiding this comment

mgyucht left a comment

Choose a reason for hiding this comment