Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK is failing in Staging #352

Closed
FastLee opened this issue Sep 19, 2023 · 1 comment · Fixed by #388
Closed

SDK is failing in Staging #352

FastLee opened this issue Sep 19, 2023 · 1 comment · Fixed by #388

Comments

@FastLee
Copy link

FastLee commented Sep 19, 2023

Description
Attempting to run Workspace SDK in our staging environment generate an error, ValueError: Not a valid Semver

Reproduction
run clusters.select_spark_version(latest=True)

Expected behavior
I expected it to work similar to any other workspace.

Debug Logs
The SDK logs helpful debugging information when debug logging is enabled. Set the log level to debug by adding logging.basicConfig(level=logging.DEBUG) to your program, and include the logs here.

Other Information

Additional context
Add any other context about the problem here.
image

@mgyucht
Copy link
Contributor

mgyucht commented Sep 20, 2023

Thanks for reporting this @FastLee! Given that this only impacts staging, this is a lower priority issue for us to look into. As a workaround for now, you can list spark versions directly and pick the version you want from the response.

github-merge-queue bot pushed a commit that referenced this issue Oct 6, 2023
## Changes
In staging, there are some spark versions that do not have a patch
version. We fall back to a different pattern with no patch component for
these. Additionally, we check if the builds are equal to one another
(which allows us to avoid comparing one < the other in the case where
they are both None).

Closes #352 and #378.

## Tests
<!-- 
How is this tested? Please see the checklist below and also describe any
other relevant tests
-->

- [x] Added a unit test with a format that was previously not supported.
- [x] Hand-wrote an example using select_spark_versions(). This failed
on `main` but passed on my branch when targeting a staging workspace.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants