Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(bugfix) Catalog GrantAPI: securable_type enum value #161

Closed

Conversation

clementboscoa
Copy link

Changes

Change the render value of securable_type attribute to have the real Enum value and not the repr value.
This will render the API URI call as the following : PATCH /api/2.1/unity-catalog/permissions/CATALOG/<catalog_id>
instead of /api/2.1/unity-catalog/permissions/SecurableType.CATALOG/<catalog_id>

Tests

Tested locally

  • make test run locally
  • make fmt applied
  • relevant integration tests applied

Change the render value of securable_type attribute to have the real value and not the repr value.

Signed-off-by: Clément Bosc /\\: (L'Oréal) <clement.bosc@loreal.com>
@nfx
Copy link
Contributor

nfx commented Jun 9, 2023

@clementboscoa unfortunately we can't accept a PR to a generated file, as it'll be overwritten. we'll fix it in one of the next releases

@nfx nfx added do-not-merge codegen issues related to generated code labels Jun 14, 2023
nfx added a commit that referenced this pull request Jun 15, 2023
@nfx
Copy link
Contributor

nfx commented Jun 15, 2023

correctly implemented in #179

@nfx nfx closed this Jun 15, 2023
nfx added a commit that referenced this pull request Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
codegen issues related to generated code do-not-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants