Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark non-required fields as Optional #170

Merged
merged 2 commits into from
Jun 14, 2023
Merged

Conversation

judahrand
Copy link
Contributor

@judahrand judahrand commented Jun 14, 2023

Changes

The code will need to be regenerated which I can't do.

Closes #169

Tests

  • make test run locally
  • make fmt applied
  • relevant integration tests applied

@nfx
Copy link
Contributor

nfx commented Jun 14, 2023

@judahrand files that start with # Code generated from OpenAPI specs by Databricks SDK Generator. DO NOT EDIT. will be silently overridden. please create github issues for those instead.

https://github.com/databricks/databricks-sdk-py/blob/main/databricks/sdk/service/jobs.py#L1

@nfx
Copy link
Contributor

nfx commented Jun 14, 2023

@judahrand you can also try to add small modifications to https://github.com/databricks/databricks-sdk-py/blob/main/.codegen/service.py.tmpl#L1-L2, but the proprietary dataset is not available to the public and there's no way to test it if you're not working for Databricks.

@judahrand
Copy link
Contributor Author

@judahrand files that start with # Code generated from OpenAPI specs by Databricks SDK Generator. DO NOT EDIT. will be silently overridden. please create github issues for those instead.

https://github.com/databricks/databricks-sdk-py/blob/main/databricks/sdk/service/jobs.py#L1

This one is the template isn't it? So this particular file isn't autogenerated if my understanding is correct?

Copy link
Contributor

@nfx nfx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nfx nfx removed the do-not-merge label Jun 14, 2023
@nfx nfx merged commit c977b90 into databricks:main Jun 14, 2023
@judahrand judahrand deleted the optional branch June 14, 2023 09:26
nfx added a commit that referenced this pull request Jun 15, 2023
* Regenerate from OpenAPI spec ([#176](#176)).
* Added improved notebook-native authentication ([#152](#152)).
* Added methods to provide extra user agent and upstream user agent to SDK config ([#163](#163)).
* Added more missing `Optional` type hints ([#171](#171)).
* Add more missing optional fields ([#177](#177)).
* Correctly serialize external entities ([#178](#178)).
* Correctly serialize external enum values in paths ([#179](#179)).
* Mark non-required fields as `Optional` ([#170](#170)).
* Synchronize auth permutation tests with Go SDK ([#165](#165)).
@nfx nfx mentioned this pull request Jun 15, 2023
1 task
nfx added a commit that referenced this pull request Jun 15, 2023
* Regenerate from OpenAPI spec
([#176](#176)).
* Added improved notebook-native authentication
([#152](#152)).
* Added methods to provide extra user agent and upstream user agent to
SDK config
([#163](#163)).
* Added more missing `Optional` type hints
([#171](#171)).
* Added more missing optional fields
([#177](#177)).
* Correctly serialize external entities
([#178](#178)).
* Correctly serialize external enum values in paths
([#179](#179)).
* Mark non-required fields as `Optional`
([#170](#170)).
* Synchronize auth permutation tests with Go SDK
([#165](#165)).

## Tests

- [x] relevant integration tests applied

---------

Signed-off-by: Serge Smertin <259697+nfx@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fields should be marked as Optional
2 participants