Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make dbutils type stubs consistent with runtime implementation #196

Merged
merged 2 commits into from
Jun 22, 2023
Merged

Conversation

kartikgupta-db
Copy link
Contributor

@kartikgupta-db kartikgupta-db commented Jun 22, 2023

Changes

  • Make dbutils type stubs consistent with the runtime implementation.

Tests

  • make test run locally
  • make fmt applied
  • relevant integration tests applied

fixes #195

@kartikgupta-db kartikgupta-db requested a review from nfx June 22, 2023 10:16
@codecov-commenter
Copy link

codecov-commenter commented Jun 22, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.05 ⚠️

Comparison is base (b5b99b7) 53.41% compared to head (2d41ff1) 53.36%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #196      +/-   ##
==========================================
- Coverage   53.41%   53.36%   -0.05%     
==========================================
  Files          29       29              
  Lines       18314    18331      +17     
==========================================
  Hits         9783     9783              
- Misses       8531     8548      +17     
Impacted Files Coverage Δ
databricks/sdk/runtime/stub.py 2.02% <0.00%> (-0.27%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@nfx nfx merged commit beb6ad1 into main Jun 22, 2023
@nfx nfx deleted the fix-stubs branch June 22, 2023 10:53
@nfx nfx mentioned this pull request Jun 28, 2023
nfx added a commit that referenced this pull request Jun 28, 2023
# Version changelog

## 0.1.12

* Beta release
([#198](#198)).
* Documentation improvements
([#197](#197)).
* Make `dbutils` type stubs consistent with runtime implementation
([#196](#196)).
* Regenerated from OpenAPI spec
([#199](#199)).

API changes:

* Renamed `compute.BaseClusterInfo` to `compute.ClusterSpec`
* Renamed `compute.ClusterInfo` to `compute.ClusterDetails`
* Renamed `jobs.JobTaskSettings` to `jobs.Task`
* Renamed `jobs.RunSubmitTaskSettings` to `jobs.SubmitTask`
* Renamed `jobs.JobWebhookNotifications` to `jobs.WebhookNotifications`
* Renamed `jobs.CreateJobFormat` to `jobs.Format`
* Renamed `jobs.GitSourceGitProvider` to `jobs.GitProvider`
* Renamed `jobs.FileArrivalTriggerSettings` to
`jobs.FileArrivalTriggerConfiguration`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect signature for dbutils.fs.mount in databricks/sdk/runtime/stub.py
3 participants