Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix debug_headers type hints #258

Merged
merged 2 commits into from
Aug 2, 2023
Merged

Fix debug_headers type hints #258

merged 2 commits into from
Aug 2, 2023
+4 −4

Conversation

alex7c4
Copy link
Contributor

@alex7c4 alex7c4 commented Jul 31, 2023 •
edited
Loading

Changes

Change debug_headers type hint from int to bool.

According to the docs it should be bool:

databricks-sdk-py/README.md

Line 235 in 519fbe3

| `debug_headers` | _(Boolean)_ `true` to debug HTTP headers of requests made by the application. Default is `false`, as headers contain sensitive data, such as access tokens. | `DATABRICKS_DEBUG_HEADERS` |

databricks-sdk-py/docs/authentication.md

Line 134 in 519fbe3

| `debug_headers` | _(Boolean)_ `true` to debug HTTP headers of requests made by the application. Default is `false`, as headers contain sensitive data, such as access tokens. | `DATABRICKS_DEBUG_HEADERS` |

Tests

  • make test run locally
  • make fmt applied
  • relevant integration tests applied --> Not applicable, no logic change

Sorry, something went wrong.

@nfx nfx enabled auto-merge (squash) August 2, 2023 12:47
@nfx nfx merged commit 3213b7b into databricks:main Aug 2, 2023
@mgyucht mgyucht mentioned this pull request Aug 2, 2023
Merged
mgyucht added a commit that referenced this pull request Aug 2, 2023
@mgyucht
Release v0.3.1
9247374 
* Added timeout to `w.clusters.ensure_cluster_running()` ([#227](#227)).
* Fixed `debug_headers` type hints for `WorkspaceClient` and `AccountClient` ([#258](#258)).
* Made dbutils typecast use a valid type variable ([#259](#259)).
mgyucht added a commit that referenced this pull request Aug 2, 2023
@mgyucht
Release v0.3.1 (#261)
38b289c 
* Added timeout to `w.clusters.ensure_cluster_running()`
([#227](#227)).
* Fixed `debug_headers` type hints for `WorkspaceClient` and
`AccountClient`
([#258](#258)).
* Made dbutils typecast use a valid type variable
([#259](#259)).
@alex7c4 alex7c4 deleted the fix_debug_headers branch August 10, 2023 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nfx nfx

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alex7c4 @nfx @mgyucht