[Internal] Single-shot upload reports content length if known #919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksafonov-db
commented
Mar 7, 2025
| @@ -1279,8 +1279,6 @@ def run(self, config: Config): | |||
|
|
|||
| session = requests.Session() | |||
| with requests_mock.Mocker(session=session) as session_mock: | |||
| session_mock.get(f"http://localhost/api/2.0/fs/files{MultipartUploadTestCase.path}", status_code=200) | |||
ksafonov-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
|
Please ensure that the NEXT_CHANGELOG.md file is updated with any relevant changes. |
ksafonov-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
|
If integration tests don't run automatically, an authorized user can run them manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
When performing single-shot upload, determine content length (via utility method from Python requests library), and if length is known, fill the
Content-LengthHTTP header. Then server will respect this header to validate request body size against.How is this tested?
Added unit test.
NO_CHANGELOG=true