Skip to content

Commit

Permalink
Removed protocol check
Browse files Browse the repository at this point in the history
Signed-off-by: nithinkdb <nithin.krishnamurthi@databricks.com>
  • Loading branch information
nithinkdb committed Jan 16, 2024
1 parent 750c8a0 commit 1648935
Showing 1 changed file with 0 additions and 7 deletions.
7 changes: 0 additions & 7 deletions connection.go
Original file line number Diff line number Diff line change
Expand Up @@ -112,9 +112,6 @@ func (c *conn) ExecContext(ctx context.Context, query string, args []driver.Name
defer log.Duration(msg, start)

corrId := driverctx.CorrelationIdFromContext(ctx)
if len(args) > 0 && c.session.ServerProtocolVersion < cli_service.TProtocolVersion_SPARK_CLI_SERVICE_PROTOCOL_V8 {
return nil, dbsqlerrint.NewDriverError(ctx, dbsqlerr.ErrParametersNotSupported, nil)
}

exStmtResp, opStatusResp, err := c.runQuery(ctx, query, args)
log, ctx = client.LoggerAndContext(ctx, exStmtResp)
Expand Down Expand Up @@ -159,10 +156,6 @@ func (c *conn) QueryContext(ctx context.Context, query string, args []driver.Nam
log, _ := client.LoggerAndContext(ctx, nil)
msg, start := log.Track("QueryContext")

if len(args) > 0 && c.session.ServerProtocolVersion < cli_service.TProtocolVersion_SPARK_CLI_SERVICE_PROTOCOL_V8 {
return nil, dbsqlerrint.NewDriverError(ctx, dbsqlerr.ErrParametersNotSupported, nil)
}

// first we try to get the results synchronously.
// at any point in time that the context is done we must cancel and return
exStmtResp, opStatusResp, err := c.runQuery(ctx, query, args)
Expand Down

0 comments on commit 1648935

Please sign in to comment.