Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose dbsql.connOption type #201

Closed
shelldandy opened this issue Apr 8, 2024 · 0 comments · Fixed by #202
Closed

Expose dbsql.connOption type #201

shelldandy opened this issue Apr 8, 2024 · 0 comments · Fixed by #202
Labels
enhancement New feature or request

Comments

@shelldandy
Copy link
Contributor

shelldandy commented Apr 8, 2024 •
edited
Loading

That way we can programmatically add arguments to the NewConnector function instead of copy/pasting all of them across conditionals.

For extra context we'd like to not repeat code everywhere depending on whether or not we're using Oauth or AccessTokens since everything else is the same but we end up with 6 calls of the same pretty much code.
@shelldandy shelldandy mentioned this issue Apr 8, 2024
Merged
@kravets-levko kravets-levko added the enhancement New feature or request label Apr 17, 2024
kravets-levko pushed a commit that referenced this issue Jul 25, 2024
@shelldandy
Expose dbsql.connOption type (#202)
f0e3a08 
Fixes: #201

That way we can programmatically add arguments to the `NewConnector`
function instead of copy/pasting all of them across conditionals.

Signed-off-by: Miguel Palau <miguel.palau@grafana.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Expose dbsql.connOption type
2 participants
@shelldandy @kravets-levko