Initial oauth implementation #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcypher-databricks
requested review from
mattdeekay,
susodapop,
yunbodeng-db and
andrefurlan-db
as code owners
rcypher-databricks
force-pushed
the
oauth
branch
from
2778c0b
to
ef1d700
Compare
|
Hi @rcypher-databricks this would be a great feature. I see it's still in draft. Curious if it's close to merge? |
Hi Scott, the plan is to get back to oauth next week. So hopefully in the next 2 weeks we'll get something released |
rcypher-databricks
force-pushed
the
oauth
branch
from
ef1d700
to
daab5bb
Compare
| } | ||
| } else { | ||
| if !hasScope(scopes, "sql") { | ||
| scopes = append(scopes, "sql") |
There was a problem hiding this comment.
should we use sql or all-apis? Gotta check with Bryan Mcquade
examples/oauth/main.go
Outdated
| connector, err := dbsql.NewConnector( | ||
| dbsql.WithServerHostname(os.Getenv("DATABRICKS_HOST")), | ||
| dbsql.WithHTTPPath(os.Getenv("DATABRICKS_HTTPPATH")), | ||
| dbsql.WithDefaultOAUTH(), |
internal/config/config.go
Outdated
| @@ -14,7 +14,8 @@ import ( | |||
|
|
|||
| "github.com/databricks/databricks-sql-go/auth" | |||
| "github.com/databricks/databricks-sql-go/auth/noop" | |||
| "github.com/databricks/databricks-sql-go/auth/pat" | |||
| "github.com/databricks/databricks-sql-go/internal/auth/oauth/defauth" | |||
| "github.com/databricks/databricks-sql-go/internal/auth/pat" | |||
There was a problem hiding this comment.
this is a breaking change!
Signed-off-by: Raymond Cypher <raymond.cypher@databricks.com>
Fixed error in default authenticator where it tried to register the same http handler multiple times. Added config decorator functions WithDefaultOAUTH, WithClientCredentials Signed-off-by: Raymond Cypher <raymond.cypher@databricks.com>
Moved implementation out of internal. Allow specifying auth type and parameters in dsn string. Refactored dsn parsing. Added tests to dsn parsing. Change default authenticator back to Noop Signed-off-by: Raymond Cypher <raymond.cypher@databricks.com>
rcypher-databricks
force-pushed
the
oauth
branch
from
d5a2292
to
5579ce8
Compare
Updated doc.go with new dsn parameters and connector functions. Signed-off-by: Raymond Cypher <raymond.cypher@databricks.com>
Signed-off-by: Raymond Cypher <raymond.cypher@databricks.com>
Signed-off-by: Raymond Cypher <raymond.cypher@databricks.com>
andrefurlan-db
approved these changes
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Oauth implementation.
Added m2m authenticator.
Added basic u2m authenticator. Implementation is broken out into public functions that clients can use to implement their own authenticator.
Allow specifying auth type and parameters in dsn.