PECO-1054 Expose Arrow batches to users #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcypher-databricks
requested review from
susodapop,
yunbodeng-db,
andrefurlan-db and
jadewang-db
as code owners
Step one of exposing arrow batches directly to users. Moved the logic for iterating of the pages in a result set into ResultPageEditor. Rows now composes in ResultPageIterator. Introduced Delimeter type. Delimeter tracks a start/end point and provides functions for determining if a point is within the delimiter range and the direction of the point if it is outside the delimeter range. Updated sparArrowBatch, arrowRowScanner, columnRows, rows to use Delimiter. Updated the Fetch logic for cloudURL and localBatch so that the concurrentFetcher doesn't need to hold or pass through a Config instance. Signed-off-by: Raymond Cypher <raymond.cypher@databricks.com>
rcypher-databricks
force-pushed
the
arrow_batches
branch
from
e2121e0
to
69bfdef
Compare
andrefurlan-db
approved these changes
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Step one of exposing arrow batches directly to users.
Moved the logic for iterating over the pages in a result set into ResultPageIterator.
Rows now composes in ResultPageIterator.
Introduced Delimeter type. Delimeter tracks a start/end point and provides functions for determining if a point is within the delimiter range and the direction of the point if it is outside the delimeter range.
Updated sparkArrowBatch, arrowRowScanner, columnRows, rows to use Delimiter.
Updated the Fetch logic for cloudURL and localBatch so that the concurrentFetcher doesn't need to hold or pass through a Config instance.