[PECO-1015] Add support for staging operations to Go Driver #164
Conversation
nithinkdb
requested review from
susodapop,
yunbodeng-db,
andrefurlan-db,
rcypher-databricks and
jadewang-db
as code owners
| for k, v := range headers { | ||
| req.Header.Set(k, v) | ||
| } | ||
| res, err := client.Do(req) |
There was a problem hiding this comment.
are we doing any retries for all the client.do calls?
There was a problem hiding this comment.
nope, that seems like overkill.
There was a problem hiding this comment.
I will leave it up to Raymond, if that's a necessary feature we can implement it, but i don't believe we do these retries in go or python
There was a problem hiding this comment.
Note that in Python we do retry these requests automatically. Presumably that happens automatically in Node as well because we use axios. So Jade's feedback makes sense here. Does the Go http library ever automatically retry?
There was a problem hiding this comment.
Outside of retriable libraries, no. https://github.com/hashicorp/go-retryablehttp -> we could hypothetically use this?
There was a problem hiding this comment.
At the very least, this seems like follow up PR material given that it is a little more involved. This PR has been sitting a bit, and doesn't really break anything. I think we should prioritize getting it in, unless we see customers complain about retry issues.
|
Are these for staging operations or UC Volumes? |
| for k, v := range headers { | ||
| req.Header.Set(k, v) | ||
| } | ||
| res, err := client.Do(req) |
There was a problem hiding this comment.
Note that in Python we do retry these requests automatically. Presumably that happens automatically in Node as well because we use axios. So Jade's feedback makes sense here. Does the Go http library ever automatically retry?
This is for UC Volumes |
nithinkdb
force-pushed
the
PECO-1015
branch
2 times, most recently
from
783efd0
to
11145ff
Compare
Signed-off-by: nithinkdb <nithin.krishnamurthi@databricks.com>
Signed-off-by: nithinkdb <nithin.krishnamurthi@databricks.com>
Signed-off-by: nithinkdb <nithin.krishnamurthi@databricks.com>
Signed-off-by: nithinkdb <nithin.krishnamurthi@databricks.com>
Signed-off-by: nithinkdb <nithin.krishnamurthi@databricks.com>
Signed-off-by: nithinkdb <nithin.krishnamurthi@databricks.com>
Signed-off-by: nithinkdb <nithin.krishnamurthi@databricks.com>
Signed-off-by: nithinkdb <nithin.krishnamurthi@databricks.com>
Signed-off-by: nithinkdb <nithin.krishnamurthi@databricks.com>
nithinkdb
force-pushed
the
PECO-1015
branch
from
a0f7fa4
to
625f6b4
Compare
We need to add support for staging operations to the go driver. This PR enabled Get, Delete, and Put operations.