-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PECO-1015] Add support for staging operations to Go Driver #164
Conversation
for k, v := range headers { | ||
req.Header.Set(k, v) | ||
} | ||
res, err := client.Do(req) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are we doing any retries for all the client.do calls?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nope, that seems like overkill.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will leave it up to Raymond, if that's a necessary feature we can implement it, but i don't believe we do these retries in go or python
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that in Python we do retry these requests automatically. Presumably that happens automatically in Node as well because we use axios
. So Jade's feedback makes sense here. Does the Go http library ever automatically retry?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Outside of retriable libraries, no. https://github.com/hashicorp/go-retryablehttp -> we could hypothetically use this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At the very least, this seems like follow up PR material given that it is a little more involved. This PR has been sitting a bit, and doesn't really break anything. I think we should prioritize getting it in, unless we see customers complain about retry issues.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just need to fix the build and linting errors.
Are these for staging operations or UC Volumes? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good but requires tests to verify the behaviour of allowed local paths.
for k, v := range headers { | ||
req.Header.Set(k, v) | ||
} | ||
res, err := client.Do(req) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that in Python we do retry these requests automatically. Presumably that happens automatically in Node as well because we use axios
. So Jade's feedback makes sense here. Does the Go http library ever automatically retry?
This is for UC Volumes |
783efd0
to
11145ff
Compare
Signed-off-by: nithinkdb <nithin.krishnamurthi@databricks.com>
Signed-off-by: nithinkdb <nithin.krishnamurthi@databricks.com>
Signed-off-by: nithinkdb <nithin.krishnamurthi@databricks.com>
Signed-off-by: nithinkdb <nithin.krishnamurthi@databricks.com>
Signed-off-by: nithinkdb <nithin.krishnamurthi@databricks.com>
Signed-off-by: nithinkdb <nithin.krishnamurthi@databricks.com>
Signed-off-by: nithinkdb <nithin.krishnamurthi@databricks.com>
Signed-off-by: nithinkdb <nithin.krishnamurthi@databricks.com>
Signed-off-by: nithinkdb <nithin.krishnamurthi@databricks.com>
a0f7fa4
to
625f6b4
Compare
We need to add support for staging operations to the go driver. This PR enabled Get, Delete, and Put operations.