Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PECO-1048] Add example for parameterized queries #168

Merged
merged 3 commits into from
Sep 29, 2023
Merged

[PECO-1048] Add example for parameterized queries #168

merged 3 commits into from
Sep 29, 2023

Conversation

nithinkdb
Copy link
Contributor

We don't currently have an example for parameterized queries, we should add one.

rcypher-databricks
rcypher-databricks reviewed Sep 27, 2023
View reviewed changes
Copy link
Contributor

@rcypher-databricks rcypher-databricks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As part of this PR please add a section in doc.go explaining the feature and how to use it.
Including things like what happens when passing raw values or sql.NamedValue as parameters.

examples/parameters/main.go Outdated Show resolved Hide resolved
@nithinkdb
Copy link
Contributor Author

As part of this PR please add a section in doc.go explaining the feature and how to use it. Including things like what happens when passing raw values or sql.NamedValue as parameters.

Adding in a future PR.

@nithinkdb
parameters example
0c5844e 
Signed-off-by: nithinkdb <nithin.krishnamurthi@databricks.com>
@nithinkdb
Fixed bugs and added example
e338383 
Signed-off-by: nithinkdb <nithin.krishnamurthi@databricks.com>
@nithinkdb
Refactored dbsqlparam
1ba2c5e 
Signed-off-by: nithinkdb <nithin.krishnamurthi@databricks.com>
@nithinkdb nithinkdb merged commit e95dd4a into databricks:main Sep 29, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rcypher-databricks rcypher-databricks rcypher-databricks approved these changes

@susodapop susodapop Awaiting requested review from susodapop

@yunbodeng-db yunbodeng-db Awaiting requested review from yunbodeng-db yunbodeng-db is a code owner

@jadewang-db jadewang-db Awaiting requested review from jadewang-db jadewang-db is a code owner

@andrefurlan-db andrefurlan-db Awaiting requested review from andrefurlan-db andrefurlan-db is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nithinkdb @andrefurlan-db @rcypher-databricks