Allow configuration overrides in the connection options #201
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the case that the user has extensions to the underlying HttpConnection instead of relying on supporting all use cases and features the consumer can simply provide a new subclass of IConnectionProvider (or subclass the existing HttpConnection) that will be used to generate new Thrift connections.
Summary of changes:
ClientOptions
passed to theDBSQLClient
to allow providing a new implementation ofIConnectionProvider
. This allows consumers to subclassHttpConnection
and for the injected dependency to be used by the client to generate thrift connections. Specifically we have customers who have unique network configurations that we'd like to be able to customize thehttp.Agent
implementation for. ExtendingHttpConnection
to provide a new agent would be the best way for us to do that.getConnectionOptions
method. This will set any that are not present but also allows for unique TLS options to be used by anyIConnectionProvider
if they are needed.rejectUnauthorized
as a possible option on the connection when using https.ConnectionOptions
implementIConnectionOptions
this
at the declaration site rather than using the runtimethis
. Mocha relies on that context and recommends not using arrow functions: https://mochajs.org/#arrow-functions