[ PECO-2065 ] Create the async execution flow for the PySQL Connector #463
Conversation
|
Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase ( |
… invalid operation handle still persists
jprakash-db
had a problem deploying
to
azure-prod
GitHub Actions
Failure
|
Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase ( |
jprakash-db
had a problem deploying
to
azure-prod
GitHub Actions
Failure
|
Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase ( |
jprakash-db
had a problem deploying
to
azure-prod
GitHub Actions
Failure
|
Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase ( |
jprakash-db
requested review from
rcypher-databricks,
yunbodeng-db,
andrefurlan-db,
jackyhu-db and
benc-db
as code owners
jprakash-db
temporarily deployed
to
azure-prod
GitHub Actions
Inactive
|
Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase ( |
| @@ -733,6 +733,7 @@ def execute( | |||
| self, | |||
| operation: str, | |||
| parameters: Optional[TParameterCollection] = None, | |||
| async_op=False, | |||
| ) -> "Cursor": | |||
| """ | |||
| Execute a query and wait for execution to complete. | |||
There was a problem hiding this comment.
Please also update the description of the method if it supports async_op or rename this method to private e.g. _execute and keep execute as sync.
| @@ -812,6 +815,44 @@ def execute( | |||
|
|
|||
| return self | |||
|
|
|||
| def execute_async( | |||
There was a problem hiding this comment.
Please include the method parameter doc and description as execute and include the return type in the method signature
| ): | ||
| return self.execute(operation, parameters, True) | ||
|
|
||
| def get_query_state(self): |
There was a problem hiding this comment.
Please include the method parameter doc and description as execute and include the return type in the method signature. e.g. -> "TOperationState":
| cursor.execute_async(long_running_query) | ||
|
|
||
| ## Polling | ||
| while isExecuting(cursor.get_query_state()): |
There was a problem hiding this comment.
Please add polling interval
| @@ -1119,7 +1161,7 @@ def __init__( | |||
| self._arrow_schema_bytes = execute_response.arrow_schema_bytes | |||
| self._next_row_index = 0 | |||
|
|
|||
| if execute_response.arrow_queue: | |||
| if execute_response.arrow_queue or async_op: | |||
There was a problem hiding this comment.
why async_op depends on arrow? What if pyarrow is not installed
| @@ -796,13 +797,15 @@ def execute( | |||
| cursor=self, | |||
| use_cloud_fetch=self.connection.use_cloud_fetch, | |||
| parameters=prepared_params, | |||
| async_op=async_op, | |||
| ) | |||
| self.active_result_set = ResultSet( | |||
There was a problem hiding this comment.
result set is not ready yet when async_op is True, why do you set this? It should be set in theget_execution_result
Description
Implementing the flow for the asynchronous execution of the execute command
Functions added
execute_async
This is the main command that will be used to execute the query, otherwise the syntax is identical to the existing execute function
get_query_state
This function is used for the purpose of polling the status of the query, to know what is the status of execution
get_execution_result
This function is used to fetch the results that have been completed and then populate the ResultSet. The flow of handling the ResultSet onwards is the same
Testing Details
Added Integration tests