Added classes required for telemetry #572

saishreeeee · 2025-05-26T06:41:39Z

What type of PR is this?

Refactor
Feature
Bug Fix
Other

Description

Added classes required for telemetry frontend logs, request and response

How is this tested?

Unit tests
E2E Tests
Manually
Verified the working of the models by sending telemetry logs to the endpoint (code for this implementation will be added in the followup PR for telemetry)
N/A

Related Tickets & Documents

PECOBLR-441

github-actions · 2025-05-26T06:41:53Z

Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase (git rebase -i main).

Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>

new codeowners Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>

…t to prevent server side resource leaks (#554) * Enhance Cursor close handling and context manager exception management * tests * fmt * Fix Cursor.close() to properly handle CursorAlreadyClosedError * Remove specific test message from Cursor.close() error handling * Improve error handling in connection and cursor context managers to ensure proper closure during exceptions, including KeyboardInterrupt. Add tests for nested cursor management and verify operation closure on server-side errors. * add * add Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>

* PECOBLR-86 Improve logging for debug level Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com> * PECOBLR-86 Improve logging for debug level Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com> * fixed format Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com> * used lazy logging Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com> * changed debug to error logs Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com> * used lazy logging Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com> --------- Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>

More conditions to run github actions Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>

Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>

jprakash-db

LGTM. Thanks for making the changes

src/databricks/sql/telemetry/models/telemetry_endpoint_models.py

Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>

samikshya-db · 2025-05-29T03:22:54Z

Let's populate the PR description, testing details. This is useful for future context.

src/databricks/sql/telemetry/enums.py

Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com> merge with origin/telemetry

Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>

samikshya-db

Excited for telemetry in python driver 🚢 !!

* PECOBLR-86 Improve logging for debug level Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com> * PECOBLR-86 Improve logging for debug level Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com> * fixed format Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com> * used lazy logging Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com> * changed debug to error logs Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com> * added classes required for telemetry Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com> * removed TelemetryHelper Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com> * [PECOBLR-361] convert column table to arrow if arrow present (#551) Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com> * Update CODEOWNERS (#562) new codeowners Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com> * Enhance Cursor close handling and context manager exception management to prevent server side resource leaks (#554) * Enhance Cursor close handling and context manager exception management * tests * fmt * Fix Cursor.close() to properly handle CursorAlreadyClosedError * Remove specific test message from Cursor.close() error handling * Improve error handling in connection and cursor context managers to ensure proper closure during exceptions, including KeyboardInterrupt. Add tests for nested cursor management and verify operation closure on server-side errors. * add * add Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com> * PECOBLR-86 improve logging on python driver (#556) * PECOBLR-86 Improve logging for debug level Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com> * PECOBLR-86 Improve logging for debug level Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com> * fixed format Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com> * used lazy logging Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com> * changed debug to error logs Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com> * used lazy logging Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com> --------- Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com> * Update github actions run conditions (#569) More conditions to run github actions Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com> * Added classes required for telemetry Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com> * fixed example Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com> * changed to doc string Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com> * removed self.telemetry close line Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com> * grouped classes Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com> * formatting Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com> * fixed doc string Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com> * fixed doc string Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com> * added more descriptive comments, put dataclasses in a sub-folder Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com> * fixed default attributes ordering Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com> * changed file names Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com> * added enums to models folder Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com> * removed telemetry batch size Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com> --------- Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com> Co-authored-by: Shivam Raj <171748731+shivam2680@users.noreply.github.com> Co-authored-by: Jothi Prakash <jothi.prakash@databricks.com> Co-authored-by: Madhav Sainanee <madhav.sainanee@databricks.com>

* PECOBLR-86 Improve logging for debug level Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com> * PECOBLR-86 Improve logging for debug level Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com> * fixed format Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com> * used lazy logging Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com> * changed debug to error logs Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com> * added classes required for telemetry Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com> * removed TelemetryHelper Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com> * [PECOBLR-361] convert column table to arrow if arrow present (#551) Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com> * Update CODEOWNERS (#562) new codeowners Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com> * Enhance Cursor close handling and context manager exception management to prevent server side resource leaks (#554) * Enhance Cursor close handling and context manager exception management * tests * fmt * Fix Cursor.close() to properly handle CursorAlreadyClosedError * Remove specific test message from Cursor.close() error handling * Improve error handling in connection and cursor context managers to ensure proper closure during exceptions, including KeyboardInterrupt. Add tests for nested cursor management and verify operation closure on server-side errors. * add * add Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com> * PECOBLR-86 improve logging on python driver (#556) * PECOBLR-86 Improve logging for debug level Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com> * PECOBLR-86 Improve logging for debug level Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com> * fixed format Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com> * used lazy logging Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com> * changed debug to error logs Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com> * used lazy logging Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com> --------- Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com> * Update github actions run conditions (#569) More conditions to run github actions Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com> * Added classes required for telemetry Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com> * fixed example Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com> * changed to doc string Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com> * removed self.telemetry close line Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com> * grouped classes Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com> * formatting Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com> * fixed doc string Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com> * fixed doc string Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com> * added more descriptive comments, put dataclasses in a sub-folder Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com> * fixed default attributes ordering Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com> * changed file names Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com> * added enums to models folder Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com> * removed telemetry batch size Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com> --------- Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com> Co-authored-by: Shivam Raj <171748731+shivam2680@users.noreply.github.com> Co-authored-by: Jothi Prakash <jothi.prakash@databricks.com> Co-authored-by: Madhav Sainanee <madhav.sainanee@databricks.com> Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>

saishreeeee requested review from deeksha-db, samikshya-db, jprakash-db, jackyhu-db, madhav-db, gopalldb, jayantsing-db, vikrantpuppala and shivam2680 as code owners May 26, 2025 06:41

saishreeeee had a problem deploying to azure-prod May 26, 2025 06:41 — with GitHub Actions Failure

saishreeeee and others added 14 commits May 26, 2025 12:12

PECOBLR-86 Improve logging for debug level

4c122b1

Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>

PECOBLR-86 Improve logging for debug level

23374be

Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>

fixed format

3971d3a

Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>

used lazy logging

91e3f40

Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>

changed debug to error logs

6331fc1

Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>

added classes required for telemetry

63593a6

Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>

removed TelemetryHelper

bb69dc9

Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>

[PECOBLR-361] convert column table to arrow if arrow present (#551)

4cb0d70

Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>

Update CODEOWNERS (#562)

d1efa03

new codeowners Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>

Update github actions run conditions (#569)

74c6463

More conditions to run github actions Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>

Added classes required for telemetry

cbc9ebf

Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>

fixed example

9d10e16

Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>

saishreeeee force-pushed the PECOBLR-441 branch from 14b0ac6 to 9d10e16 Compare May 26, 2025 06:43

saishreeeee temporarily deployed to azure-prod May 26, 2025 06:43 — with GitHub Actions Inactive

saishreeeee had a problem deploying to azure-prod May 26, 2025 06:43 — with GitHub Actions Failure

saishreeeee changed the base branch from main to telemetry May 26, 2025 06:50

Merge branch 'origin/telemetry' into PECOBLR-441

1c467f3

Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>

saishreeeee had a problem deploying to azure-prod May 28, 2025 04:41 — with GitHub Actions Failure

fixed default attributes ordering

74ea9b6

Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>

saishreeeee had a problem deploying to azure-prod May 28, 2025 04:49 — with GitHub Actions Failure

jprakash-db approved these changes May 28, 2025

View reviewed changes

vikrantpuppala reviewed May 28, 2025

View reviewed changes

src/databricks/sql/telemetry/models/telemetry_endpoint_models.py Outdated Show resolved Hide resolved

saishreeeee had a problem deploying to azure-prod May 28, 2025 08:59 — with GitHub Actions Failure

changed file names

ac7881f

Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>

saishreeeee had a problem deploying to azure-prod May 28, 2025 09:02 — with GitHub Actions Failure

saishreeeee temporarily deployed to azure-prod May 28, 2025 09:02 — with GitHub Actions Inactive

saishreeeee had a problem deploying to azure-prod May 28, 2025 10:32 — with GitHub Actions Failure

saishreeeee had a problem deploying to azure-prod May 28, 2025 16:26 — with GitHub Actions Failure

saishreeeee had a problem deploying to azure-prod May 28, 2025 17:01 — with GitHub Actions Failure

saishreeeee had a problem deploying to azure-prod May 28, 2025 18:19 — with GitHub Actions Failure

saishreeeee had a problem deploying to azure-prod May 28, 2025 18:59 — with GitHub Actions Failure

samikshya-db reviewed May 29, 2025

View reviewed changes

src/databricks/sql/telemetry/enums.py Outdated Show resolved Hide resolved

Merge remote-tracking branch 'origin/telemetry' into PECOBLR-441

bff17b5

Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com> merge with origin/telemetry

saishreeeee had a problem deploying to azure-prod May 29, 2025 03:32 — with GitHub Actions Failure

added enums to models folder

6219d38

Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>

saishreeeee had a problem deploying to azure-prod May 29, 2025 03:37 — with GitHub Actions Failure

removed telemetry batch size

6305323

Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>

saishreeeee had a problem deploying to azure-prod May 29, 2025 04:55 — with GitHub Actions Failure

saishreeeee requested a review from samikshya-db May 29, 2025 05:06

saishreeeee self-assigned this May 29, 2025

samikshya-db approved these changes May 29, 2025

View reviewed changes

saishreeeee merged commit fdd385f into telemetry May 30, 2025
22 of 23 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Added classes required for telemetry #572

Added classes required for telemetry #572

saishreeeee commented May 26, 2025 •

edited

Loading

Uh oh!

github-actions bot commented May 26, 2025

Uh oh!

jprakash-db left a comment

Uh oh!

Uh oh!

samikshya-db commented May 29, 2025

Uh oh!

Uh oh!

samikshya-db left a comment

Uh oh!

Uh oh!

Uh oh!

Added classes required for telemetry #572

Added classes required for telemetry #572

Conversation

saishreeeee commented May 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What type of PR is this?

Description

How is this tested?

Related Tickets & Documents

Uh oh!

github-actions bot commented May 26, 2025

Uh oh!

jprakash-db left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

samikshya-db commented May 29, 2025

Uh oh!

Uh oh!

samikshya-db left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

saishreeeee commented May 26, 2025 •

edited

Loading