SEA: Cleanup

[varun-edachali-dbx]

What type of PR is this?

• Refactor

Description

• Remove Client param from ResultSet, infer from Connection instead
• Consider grouping primitive types in Session constructor into a type / namedtuple ConnectionParams
• Evaluate setting session closed flag in the beginning of session close() (currently set at the end)
  • decision: the session closed flag should be set at the end of the session's close method. The flag should only be set if the session has successfully closed. Setting the flag at the beginning would lead to a resource leak because if the session closure fails and the user attempts to clean up resources by attempting to close() again, our code would disallow another request being made because we already consider the session to be closed.
    • pros: logical coherence - the session is only marked as closed if it successfully gets closed + maintenance of existing behaviour
    • cons: the session may not actually get closed despite the user attempting a close().
• Remove service specific state from ExecuteResponse
• Re-organise sea/ and backend/ relation

How is this tested?

• Unit tests
• E2E Tests
• Manually
• N/A

Related Tickets & Documents

PECOBLR-531
PECOBLR-447
PECOBLR-448
PECOBLR-603
PECOBLR-606