Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Sync fails for spaces in foldernames #555

Closed
AndreiCalin24 opened this issue Mar 13, 2023 · 3 comments · Fixed by #561
Closed

[BUG] Sync fails for spaces in foldernames #555

AndreiCalin24 opened this issue Mar 13, 2023 · 3 comments · Fixed by #561
Assignees
Labels
bug Something isn't working

Comments

@AndreiCalin24
Copy link

Describe the bug
When trying to sync a repo that contains folders with spaces in names, Sync fails.

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'Databricks Extension'
  2. Click on 'Sync Destination'
  3. See error

Screenshots
If applicable, add screenshots to help explain your problem.
image

System information:

  1. Paste the output of the Help: About command (CMD-Shift-P).
    Version: 1.76.1 (system setup)
    Commit: 5e805b79fcb6ba4c2d23712967df89a089da575b
    Date: 2023-03-08T16:32:00.131Z
    Electron: 19.1.11
    Chromium: 102.0.5005.196
    Node.js: 16.14.2
    V8: 10.2.154.26-electron.0
    OS: Windows_NT x64 10.0.19044
    Sandboxed: Yes

  2. Databricks Extension Version
    v0.3.4

Databricks Extension Logs
Please attach the databricks extension logs

Additional context
Add any other context about the problem here.

@AndreiCalin24 AndreiCalin24 added the bug Something isn't working label Mar 13, 2023
@kartikgupta-db
Copy link
Contributor

Hi @AndreiCalin24 thanks for reporting this! We will have this fixed asap.

@AndreiCalin24
Copy link
Author

I realised I forgot to mention this which might be helpful.

Normally you would be able to see this in the screenshot but I had to mask the folders names.

In the POST request, spaces in folder names get replaced with + symbols. Thus, my guess is that looks for 'Folder+Name' instead of Folder Name (which actually exists in the destination).

If I manually create a folder 'Folder+Name' in the destination, it's correctly pushing and syncing the files.

@shreyas-goenka
Copy link
Contributor

Thanks for the update! We found the bug, there was a mistake in the way we encoded the URL path

fjakobs pushed a commit that referenced this issue Mar 16, 2023
This includes fix for syncing issues with " ", "+" and "#" characters

Fixes #555 
Fixes #468

---------

Co-authored-by: Kartik Gupta <88345179+kartikgupta-db@users.noreply.github.com>
kartikgupta-db added a commit that referenced this issue Mar 20, 2023
## packages/databricks-vscode
## <small>0.3.5 (2023-03-17)</small>

* Add prompts to switch to repos when Files in Workspace is not
supported (#376)
([646601a](646601a)),
closes
[#376](#376)
* bump bricks to v0.0.27 (#561)
([a9b74bd](a9b74bd)),
closes
[#561](#561)
[#555](#555)
[#468](#468)
* Prevent relogin when project.json is updated on first login (#565)
([1f391e2](1f391e2)),
closes
[#565](#565)
* Provide default sync destination if not set (#569)
([0a641d4](0a641d4)),
closes
[#569](#569)
* Wrapper for workflow runs from files in workspace (#556)
([5616198](5616198)),
closes
[#556](#556)



## packages/databricks-sdk-js
## <small>0.3.5 (2023-03-17)</small>

* Update OpenAPI (#568)
([a944ed0](a944ed0)),
closes
[#568](#568)
* Wrapper for workflow runs from files in workspace (#556)
([5616198](5616198)),
closes
[#556](#556)



## packages/databricks-vscode-types
## <small>0.3.5 (2023-03-17)</small>

---------

Co-authored-by: releasebot <noreply@github.com>
Co-authored-by: kartikgupta-db <kartik.gupta@databricks.com>
Co-authored-by: Kartik Gupta <88345179+kartikgupta-db@users.noreply.github.com>
Co-authored-by: Fabian Jakobs <fabian.jakobs@databricks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants