Set upper bound for Python #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ueshin
commented
Aug 11, 2022
| ], | ||
| python_requires=">=3.7", | ||
| python_requires=">=3.7,<3.10", |
There was a problem hiding this comment.
This might be good enough without explicitly setting the upper bound. We could just say dbt-databricks does not officially support Python 3.10 yet.
@allisonwang-db WDYT?
There was a problem hiding this comment.
Yea this should be fine.
allisonwang-db
approved these changes
Aug 11, 2022
| ], | ||
| python_requires=">=3.7", | ||
| python_requires=">=3.7,<3.10", |
There was a problem hiding this comment.
Yea this should be fine.
|
Thanks! merging. |
ext-gvillafane
pushed a commit
to AdelanteFinancialHoldings/dbt-databricks
that referenced
this pull request
Aug 12, 2022
### Description The dependent library `databricks-sql-connector` doesn't support Python 3.10 yet (databricks/databricks-sql-python#26). We should also avoid incompatible Python version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The dependent library
databricks-sql-connectordoesn't support Python 3.10 yet (databricks/databricks-sql-python#26).We should also avoid incompatible Python version.