Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert df to pyspark DataFrame if it is pandas or pandas-on-Spark before writing #181

Merged

Conversation

dbeatty10
Copy link
Contributor

@dbeatty10 dbeatty10 commented Sep 20, 2022

resolves #179

Description

Per #180 (comment) removing py_write_table macro since dbt-labs/dbt-spark#469 is merged.

Checklist

  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change to the "dbt-databricks next" section.

@dbeatty10 dbeatty10 marked this pull request as ready for review September 20, 2022 16:20
Copy link
Collaborator

@ueshin ueshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise, LGTM.

CHANGELOG.md Outdated
@@ -2,6 +2,7 @@

### Features
- Support python model through run command API, currently supported materializations are table and incremental. ([dbt-labs/dbt-spark#377](https://github.com/dbt-labs/dbt-spark/pull/377), [#126](https://github.com/databricks/dbt-databricks/pull/126))
- Enable Pandas and Pandas-on-Spark DataFrames for dbt python models ([#181](https://github.com/databricks/dbt-databricks/pull/181))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also add the PR link in dbt-spark, like [dbt-labs/dbt-spark#469](https://github.com/dbt-labs/dbt-spark/pull/469). See the above item.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call. Just pushed that commit.

@ueshin
Copy link
Collaborator

ueshin commented Sep 20, 2022

Thanks for working on this! merging.

@ueshin ueshin merged commit a9f5cad into databricks:main Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable pandas and pandas-on-Spark DataFrames for Databricks
2 participants