Use builtin timestampadd and timestampdiff functions for dateadd/datediff macros if available. #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…diff macros if available.
zhengruifeng
approved these changes
Sep 26, 2022
allisonwang-db
approved these changes
Sep 26, 2022
| @@ -59,6 +60,19 @@ class DatabricksAdapter(SparkAdapter): | |||
|
|
|||
| AdapterSpecificConfigs = DatabricksConfig | |||
|
|
|||
| @available.parse(lambda *a, **k: 0) | |||
There was a problem hiding this comment.
Just curious, why do we need this @available.parse?
There was a problem hiding this comment.
Methods to be exposed to macros need to be marked with @available or its variants.
And without @available.parse, the function will be executed even at parse time that causes InvalidConnectionException because connections are not available at parse time.
A decorator factory to indicate that a method on the adapter will be
exposed to the database wrapper, and will be stubbed out at parse time
with the given function.
|
Thanks! merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Uses builtin
timestampaddandtimestampdifffunctions fordateadd/datediffmacros if available.The functions timestampadd and timestampdiff have been available since DBR 10.4. Those are equivalent to what
dateadd/datediffmacros are trying to achieve.