Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add databricks-sql-connector support. #3

Merged
merged 3 commits into from
Oct 27, 2021
Merged

Add databricks-sql-connector support. #3

merged 3 commits into from
Oct 27, 2021

Conversation

ueshin
Copy link
Collaborator

@ueshin ueshin commented Oct 26, 2021

Description

Adds databricks-sql-connector support.

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change to the "dbt-spark next" section.

@@ -49,7 +52,8 @@ def _build_odbc_connnection_string(**kwargs) -> str:
return ";".join([f"{k}={v}" for k, v in kwargs.items()])


class SparkConnectionMethod(StrEnum):
class DatabricksConnectionMethod(StrEnum):
DBSQL = 'dbsql'
Copy link
Collaborator Author

@ueshin ueshin Oct 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be a better name?

@ueshin ueshin merged commit 1540e29 into databricks:main Oct 27, 2021
@ueshin ueshin deleted the dbsql branch October 27, 2021 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant