Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Another usage of limit param #395

Conversation

dataders
Copy link
Contributor

Description

This is a follow-on to #392 to completely implement the changes needed as a result of dbt-labs/dbt-core#7545

Previously, I had only given guidance that DatabricksConnectionManager.execute() was the only place where limit should be added.

However, TIL that dbt-databricks overrides dbt-core's BaseAdapter.execute(), therefore that function signature must also be updated. This was a miss on my part, because AFAIK, dbt-databricks is the only adapter doing this. I updated dbt-labs/dbt-core#7958 to reflect this information.

Perhaps there's a follow-up item where can revisit the use case of overriding that method and if there's an alternative way to handle __tmp tables.

Checklist

  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change to the "dbt-databricks next" section.

@dataders dataders changed the base branch from main to 1.6.latest July 27, 2023 15:18
@rcypher-databricks rcypher-databricks merged commit 65138f6 into databricks:1.6.latest Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants