Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a follow-on to #392 to completely implement the changes needed as a result of dbt-labs/dbt-core#7545
Previously, I had only given guidance that
DatabricksConnectionManager.execute()
was the only place where limit should be added.However, TIL that dbt-databricks overrides dbt-core's
BaseAdapter.execute()
, therefore that function signature must also be updated. This was a miss on my part, because AFAIK, dbt-databricks is the only adapter doing this. I updated dbt-labs/dbt-core#7958 to reflect this information.Perhaps there's a follow-up item where can revisit the use case of overriding that method and if there's an alternative way to handle
__tmp
tables.Checklist
CHANGELOG.md
and added information about my change to the "dbt-databricks next" section.