add fetchmany, resolves #408 #409
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 7, 2023 21:18
Signed-off-by: Jessica Smith <jessica.smith@getrhyme.com>
Signed-off-by: Jessica Smith <jessica.smith@getrhyme.com>
NodeJSmith
requested review from
andrefurlan-db,
susodapop and
ueshin
as code owners
|
I didn't add any tests because I wasn't sure what to add. I did run the existing endpoint tests, both uc/non-uc as well as the uc-cluster tests, everything has passed. |
|
@susodapop looks good to me, thoughts? I've verified that the issue still exists in 1.6.1 in my local project. |
|
@NodeJSmith thanks for the contribution and apologies for the delay in communication. |
|
Couldn't figure out how to push to here, so opened a new PR that updates the Changelog. #440 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #408
Description
Adds a
fetchmanyfunction that callsfetchmanyon underlying cursorChecklist
CHANGELOG.mdand added information about my change to the "dbt-databricks next" section.