Add SQL Endpoint specific integration tests. #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a new test profile and env variable DBT_DATABRICKS_ENDPOINT_HTTP_PATH
ueshin
reviewed
Feb 3, 2022
| [testenv:integration-spark-databricks-sql-endpoint-connector] | ||
| basepython = python3.8 | ||
| commands = /bin/bash -c '{envpython} -m pytest -v tests/specs/spark-databricks-sql-endpoint-connector.dbtspec' | ||
| /bin/bash -c '{envpython} -m pytest -v -m profile_databricks_sql_connector {posargs} -n4 tests/integration/*' |
There was a problem hiding this comment.
The profile name should be profile_databricks_sql_endpoint_connector, and we need to enable the custom integration tests for the profile, e.g., in test_incremental_strategies.py:
@use_profile("databricks_sql_endpoint_connector")
def test_default_append_databricks_sql_endpoint_connector(self):
self.run_and_test()
|
Thanks! I'd merge this now, and address my comment and refine the integration tests. |
ueshin
pushed a commit
that referenced
this pull request
Feb 4, 2022
Adds a new test profile and env variable DBT_DATABRICKS_ENDPOINT_HTTP_PATH ### Description Some features behave differently on sql endpoints vs spark clusters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new test profile and env variable DBT_DATABRICKS_ENDPOINT_HTTP_PATH
Description
Some features behave differently on sql endpoints vs spark clusters.