Stop setting cluster by to None #806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benc-db
requested review from
andrefurlan-db and
rcypher-databricks
as code owners
jackyhu-db
approved these changes
Sep 25, 2024
benc-db
added a commit
that referenced
this pull request
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #805
Description
This fixes 805, though 805 raises a bigger question about whether its reasonable for users to materialize things outside of dbt, and expect dbt to handle that gracefully if you don't add matching config to the project. Setting that aside, actually getting rid of this clause because I think it's more reasonable for someone to do a full refresh if they want to get rid of liquid clustering than it is to run cluster by none on every Delta incremental run.
Checklist
CHANGELOG.mdand added information about my change to the "dbt-databricks next" section.