Cleanup warnings and test issues #843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benc-db
requested review from
andrefurlan-db and
rcypher-databricks
as code owners
jackyhu-db
reviewed
Nov 13, 2024
| @@ -5,7 +5,8 @@ | |||
| from dbt.artifacts.schemas.results import RunStatus | |||
|
|
|||
|
|
|||
| @pytest.mark.skip_profile("databricks_cluster") | |||
| # @pytest.mark.skip_profile("databricks_cluster") | |||
There was a problem hiding this comment.
why do you comment out instead of deleting it?
There was a problem hiding this comment.
It's only temporary until next week, when the fix will get released to prod.
jackyhu-db
approved these changes
Nov 13, 2024
eric-wang-1990
approved these changes
Nov 13, 2024
This was referenced Nov 22, 2024
This was referenced Dec 10, 2024
tatiana
pushed a commit
to astronomer/astronomer-cosmos
that referenced
this pull request
Dec 10, 2024
Our CI is broken due to a `dbt-databricks` release with conflicting dependencies with `Airflow>=2.8`. The latest release of`dbt-databricks` has pinned the Pydantic to `"pydantic>=1.10.0, <2"` https://github.com/databricks/dbt-databricks/blob/main/pyproject.toml#L33-L33 This change was added in PR: databricks/dbt-databricks#843 and released on 9 December as part of `dbt-databricks==1.9.0` (https://pypi.org/project/dbt-databricks/1.9.0/). The `debt-data bricks` conflicts with the neAirflow version, which that requires Pydantic 2.0. For Airflow < 2.8, things work as expected: https://github.com/astronomer/astronomer-cosmos/actions/runs/12259335118/job/34201293598. In this PR, I'm pinning dbt-databricks version to < 1.9 to make CI green again. Follow-up PR: #1379
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Dbt asked me to not require pydantic > 2 (as it was causing issues). So I wrote all of my pydantic in v1; however, if pydantic v2 got installed, a bunch of warnings would be emitted. So now restricting to < 2.
Marked failing iceberg tests as skip for now (since there is an issue in prod).
Checklist
CHANGELOG.mdand added information about my change to the "dbt-databricks next" section.