Jetty patch to avoid hanging threads #5
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The investigation of https://databricks.atlassian.net/browse/PROD-35631 suggested a jetty websocket's
sendString()
can lead to the calling thread hanging on blockingWrite (See jetty#2061 for the OSS discussion).This PR implemented the workaround that's suggested by the OSS community (jetty#2061 (comment)) to avoid hanging threads like
Please note that branch
origin/jetty-patch-to-avoid-hanging-threads
is directly checked out from tagjetty-9.3.30.v20211001
(used by webapp):We plan to publish this change to
origin/jetty-patch-to-avoid-hanging-threads
as a new version, and then apply it to webapp repo.