Add ability to include code in --tla-code and --tla-code-file #175
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to the
--ext-code
changes in #171,--tla-code
is meant to be able to take arbitrary Jsonnet code just like--ext-code
can, and before this PR we limited it to only JSONI refactored out the common
Interpreter#parseVar
logic so it can be shared between both, and added new tests to exercise the new behavior.The
override def evalDefault
for theVal.Func
used for top-level functions needed to be fixed; there was always a logical issue evaluating the--tla-code
expression using the main file'sValScope
, but it didn't matter since previously we only allowed JSON so there weren't any identifiers to look up using it. Now that there are, the correct thing to do is to evaluate the--tla-code
expression usingValScope.empty
, since it is meant to be a standalone expression without any existing local bindings in its lexical scopeNotably,
--tla-code
expressions cannot reference each other the way--ext-code
expressions can, so there is no equivalent to thestdExtVarRecursive
test case. They can still callstd
functions, so thestd
test case remains