Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: std.manifestJsonMinified and empty arrays/objects. #207

Conversation

rudo-thomas
Copy link
Contributor

Problem: std.manifestJsonMinified was producing newlines in empty arrays or empty objects:

$ jsonnet -e 'std.manifestJsonMinified({a:[],b:{}})'
"{\"a\":[],\"b\":{}}"

$ sjsonnet-0.4.10 -e 'std.manifestJsonMinified({a:[],b:{}})'
"{\"a\":[\n],\"b\":{\n}}"

Fix that and update the tests too.

Problem: std.manifestJsonMinified was producing newlines in empty arrays
or empty objects:
```
$ jsonnet -e 'std.manifestJsonMinified({a:[],b:{}})'
"{\"a\":[],\"b\":{}}"

$ sjsonnet-0.4.10 -e 'std.manifestJsonMinified({a:[],b:{}})'
"{\"a\":[\n],\"b\":{\n}}"
```

Fix that and update the tests too.
@stephenamar-db stephenamar-db merged commit 6c0db97 into databricks:master Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants