This repository was archived by the owner on Dec 20, 2018. It is now read-only.
Reader writer improvements #283
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #283 +/- ##
==========================================
- Coverage 92.23% 91.97% -0.27%
==========================================
Files 5 6 +1
Lines 322 324 +2
Branches 43 39 -4
==========================================
+ Hits 297 298 +1
- Misses 25 26 +1 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr saves on string conversions by explicitly making the generic datum reader read strings instead of utf-8.
Also, the converter copies every object from the record read by the reader but the iterator never actually reused any record instance. Now record is reused per iterator for efficient memory reuse