This repository was archived by the owner on Dec 20, 2018. It is now read-only.
Do not ignore avro files without extensions by default #286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #286 +/- ##
==========================================
+ Coverage 92.23% 92.56% +0.33%
==========================================
Files 5 5
Lines 322 323 +1
Branches 43 41 -2
==========================================
+ Hits 297 299 +2
+ Misses 25 24 -1 |
MaxGekk
changed the title
Contributor
|
Left some comments in apache/spark#21769 . |
Member
Author
|
@gengliangwang I ported the commit apache/spark@ba437fc . Please, take a look at the PR again. |
Contributor
|
Thanks, merge to master. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In the PR, I propose to change the default behaviour of AVRO datasource which currently ignores files without
.avroextension in read by default. This PR sets the default value foravro.mapred.ignore.inputs.without.extensiontofalsein the case if the parameter is not set by an user.How was this patch tested?
Added a test file without extension in AVRO format, and new test for reading the file with and wihout specified schema.