Fix bug in overwrite when using schema-qualified table names #102
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes #97, an issue where using
SaveMode.Overwritewith schema-qualified table names (such asmy_schema.my_table) would lead to "Invalid operation: syntax error at or near ".";" messages from Redshift.The problem is that the
ALTER TABLE ... RENAMEcommand only accepts unqualified table names as the new names, so we need to strip off the schema prior to performing the renaming.In order to keep this code clean, this patch introduces a new
TableNamecase class which manages all of the escaping and parsing logic for table names, then uses that class to fix the Overwrite issue.