Skip to content

Conversation

@JoshRosen
Copy link
Contributor

This commit updates the build and examples to use the Amazon Redshift JDBC Driver.

@JoshRosen
Copy link
Contributor Author

AFAIK this use is compatible with the driver's license terms: https://s3.amazonaws.com/redshift-downloads/drivers/Amazon+Redshift+JDBC+Driver+License+Agreement.pdf

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here, I chose to use the JDBC 4.0 driver instead of 4.1 in order to retain Java 6 support.

@codecov-io
Copy link

Current coverage is 85.90%

Merging #42 into master will increase coverage by +20.24% as of e5c9d48

@@            master    #42   diff @@
=====================================
  Files           10      9     -1
  Stmts          399    305    -94
  Branches        81     70    -11
  Methods          0      0       
=====================================
  Hit            262    262       
  Partial          0      0       
+ Missed         137     43    -94

Review entire Coverage Diff as of e5c9d48

Powered by Codecov. Updated on successful CI builds.

@JoshRosen
Copy link
Contributor Author

This should now be ready for review + commit.

@JoshRosen
Copy link
Contributor Author

This was LGTM'd offline, so I'm going to merge now and will rebase my other PR.

@JoshRosen JoshRosen closed this in f2daf23 Aug 20, 2015
@JoshRosen JoshRosen deleted the use-amazon-driver branch August 20, 2015 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants