Skip to content

Conversation

@JoshRosen
Copy link
Contributor

This commit copies JDBC code from Spark in order to minimize this library's reliance on private Spark APIs. This partially addresses #40; that issue can be completely resolved once we publish Maven snapshots for 1.5.0 and are able to test against that version in Travis.

@codecov-io
Copy link

Current coverage is 65.99%

Merging #46 into master will decrease coverage by -18.53% as of e75ee3f

@@            master     #46   diff @@
======================================
  Files           10      10       
  Stmts          310     397    +87
  Branches        70      81    +11
  Methods          0       0       
======================================
  Hit            262     262       
  Partial          0       0       
- Missed          48     135    +87

Review entire Coverage Diff as of e75ee3f

Powered by Codecov. Updated on successful CI builds.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a comment about what is going on here and why we are using reflection.

@marmbrus
Copy link
Contributor

a few comments but generally LGTM

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Turns out that Redshift doesn't support this type either.

@JoshRosen
Copy link
Contributor Author

Updated to address comments. Still need to update to fix a bug which isn't caught by the existing tests (but which is caught in my testing branch). Once I do that, I'm going to merge this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants