Deprecate several APIs before 0.5.0 release#65
Closed
Conversation
Current coverage is
|
Contributor
Author
|
I'm going to merge this now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit deprecates several APIs in advance of the 0.5.0 release:
redshiftFilewhich accepts a schema string. This code path is not tested and is likely to diverge over time. Most users will be better off using the data sources API or performing the type casts themselves.overwriteconfiguration option, which is only used by the deprecated APIs. For consistency / minimizing the testing surface, I think that the code paths for dealing with overwriting should be written with reference to data sources'SaveModeAPI. I'm going to add some additional unit tests for this in a separate followup PR to make sure that theSaveModeflags are handled properly.