spark-xml fails to load xml files with comments

[deenar]

I found that spark-xml fails to load documents with comments in them. Has anyone else encountered this or I am doing something wrong. Here is a sample document I am having trouble with.

Sample Document with comments

<?xml version="1.0" encoding="utf-8"?>
<!--
  == Copyright (c) 2002-2015 All rights reserved.
  == Financial Products Markup Language is subject to the FpML public license.
  == A copy of this license is available at http://www.fpml.org/license/license.html
  -->
<dataDocument xmlns="http://www.fpml.org/FpML-5/master" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" fpmlVersion="5-8" xsi:schemaLocation="http://www.fpml.org/FpML-5/master ../../../schema/fpml-main.xsd http://www.w3.org/2000/09/xmldsig# ../../../schema/xmldsig-core-schema.xsd">
    <trade>
        <tradeHeader>
            <partyTradeIdentifier>
                <partyReference href="Party1"/>
                <tradeId tradeIdScheme="http://www.partyA.com/swaps/trade-id">Party19235</tradeId>
            </partyTradeIdentifier>
            <partyTradeIdentifier>
                <partyReference href="Party2"/>
                <tradeId tradeIdScheme="http://www.barclays.com/swaps/trade-id">Party22000</tradeId>
            </partyTradeIdentifier>
            <tradeDate>2014-11-19</tradeDate>
        </tradeHeader>
        <repo>
            <productType productTypeScheme="http://www.example.org/coding-scheme/product-taxonomy">InterestRate:Repo:BondRepo</productType>
            <productId productIdScheme="http://www.example.org/coding-scheme/product-id">Repo</productId>
            <fixedRateSchedule>
                <initialValue>0.85</initialValue>
            </fixedRateSchedule>
            <dayCountFraction>ACT/ACT.ICMA</dayCountFraction>
            <callingParty>AsDefinedInMasterAgreement</callingParty>
            <initialMargin>
                <marginType>Cash</marginType>
                <marginRatio>1.25</marginRatio>
            </initialMargin>
            <nearLeg>
                <buyerPartyReference href="Party1"/>
                <sellerPartyReference href="Party2"/>
                <settlementDate>
                    <adjustableDate>
                        <unadjustedDate>2014-11-03</unadjustedDate>
                        <dateAdjustments>
                            <businessDayConvention>NONE</businessDayConvention>
                        </dateAdjustments>
                    </adjustableDate>
                </settlementDate>
                <deliveryMethod>DeliveryVersusPayment</deliveryMethod>
                <settlementAmount>
                    <currency>USD</currency>
                    <amount>782855.55</amount>
                </settlementAmount>
                <collateral>
                    <nominalAmount>
                        <currency>USD</currency>
                        <amount>1000000</amount>
                    </nominalAmount>
                    <cleanPrice>97.8569437</cleanPrice>
                    <accruals>9.250000</accruals>
                    <dirtyPrice>107.1069437</dirtyPrice>
                    <assetReference href="XSJKL"/>
                </collateral>
            </nearLeg>
            <bond id="XSJKL">
                <instrumentId instrumentIdScheme="isin">JKL Corp Bond</instrumentId>
            </bond>
        </repo>
    </trade>
    <party id="Party1">
        <partyId>Party 1</partyId>
    </party>
    <party id="Party2">
        <partyId>Party 2</partyId>
    </party>
</dataDocument>

[HyukjinKwon]

@deenar Thanks for reporting this.

[HyukjinKwon]

@deenar It looks this is fixed in the master branch but a release has not been published yet. I just tested this with the data above with the latest one and it looks working fine with the result below.

• Schema

root
 |-- @fpmlVersion: string (nullable = true)
 |-- @schemaLocation: string (nullable = true)
 |-- @xmlns: string (nullable = true)
 |-- @xsi: string (nullable = true)
 |-- party: array (nullable = true)
 |    |-- element: struct (containsNull = true)
 |    |    |-- @id: string (nullable = true)
 |    |    |-- partyId: string (nullable = true)
 |-- trade: struct (nullable = true)
 |    |-- repo: struct (nullable = true)
 |    |    |-- bond: struct (nullable = true)
 |    |    |    |-- @id: string (nullable = true)
 |    |    |    |-- instrumentId: struct (nullable = true)
 |    |    |    |    |-- #VALUE: string (nullable = true)
 |    |    |    |    |-- @instrumentIdScheme: string (nullable = true)
 |    |    |-- callingParty: string (nullable = true)
 |    |    |-- dayCountFraction: string (nullable = true)
 |    |    |-- fixedRateSchedule: struct (nullable = true)
 |    |    |    |-- initialValue: double (nullable = true)
 |    |    |-- initialMargin: struct (nullable = true)
 |    |    |    |-- marginRatio: double (nullable = true)
 |    |    |    |-- marginType: string (nullable = true)
 |    |    |-- nearLeg: struct (nullable = true)
 |    |    |    |-- buyerPartyReference: struct (nullable = true)
 |    |    |    |    |-- #VALUE: string (nullable = true)
 |    |    |    |    |-- @href: string (nullable = true)
 |    |    |    |-- collateral: struct (nullable = true)
 |    |    |    |    |-- accruals: double (nullable = true)
 |    |    |    |    |-- assetReference: struct (nullable = true)
 |    |    |    |    |    |-- #VALUE: string (nullable = true)
 |    |    |    |    |    |-- @href: string (nullable = true)
 |    |    |    |    |-- cleanPrice: double (nullable = true)
 |    |    |    |    |-- dirtyPrice: double (nullable = true)
 |    |    |    |    |-- nominalAmount: struct (nullable = true)
 |    |    |    |    |    |-- amount: long (nullable = true)
 |    |    |    |    |    |-- currency: string (nullable = true)
 |    |    |    |-- deliveryMethod: string (nullable = true)
 |    |    |    |-- sellerPartyReference: struct (nullable = true)
 |    |    |    |    |-- #VALUE: string (nullable = true)
 |    |    |    |    |-- @href: string (nullable = true)
 |    |    |    |-- settlementAmount: struct (nullable = true)
 |    |    |    |    |-- amount: double (nullable = true)
 |    |    |    |    |-- currency: string (nullable = true)
 |    |    |    |-- settlementDate: struct (nullable = true)
 |    |    |    |    |-- adjustableDate: struct (nullable = true)
 |    |    |    |    |    |-- dateAdjustments: struct (nullable = true)
 |    |    |    |    |    |    |-- businessDayConvention: string (nullable = true)
 |    |    |    |    |    |-- unadjustedDate: string (nullable = true)
 |    |    |-- productId: struct (nullable = true)
 |    |    |    |-- #VALUE: string (nullable = true)
 |    |    |    |-- @productIdScheme: string (nullable = true)
 |    |    |-- productType: struct (nullable = true)
 |    |    |    |-- #VALUE: string (nullable = true)
 |    |    |    |-- @productTypeScheme: string (nullable = true)
 |    |-- tradeHeader: struct (nullable = true)
 |    |    |-- partyTradeIdentifier: array (nullable = true)
 |    |    |    |-- element: struct (containsNull = true)
 |    |    |    |    |-- partyReference: struct (nullable = true)
 |    |    |    |    |    |-- #VALUE: string (nullable = true)
 |    |    |    |    |    |-- @href: string (nullable = true)
 |    |    |    |    |-- tradeId: struct (nullable = true)
 |    |    |    |    |    |-- #VALUE: string (nullable = true)
 |    |    |    |    |    |-- @tradeIdScheme: string (nullable = true)
 |    |    |-- tradeDate: string (nullable = true)

• Result

+------------+--------------------+--------------------+--------------------+--------------------+--------------------+
|@fpmlVersion|     @schemaLocation|              @xmlns|                @xsi|               party|               trade|
+------------+--------------------+--------------------+--------------------+--------------------+--------------------+
|         5-8|http://www.fpml.o...|http://www.fpml.o...|http://www.w3.org...|[[Party1,Party 1]...|[[[XSJKL,[JKL Cor...|
+------------+--------------------+--------------------+--------------------+--------------------+--------------------+

[spiu]

I can confirm this is fixed too

[HyukjinKwon]

@spiu Thanks.

[HyukjinKwon]

This will be fixed in #110 and #166.

I am closing this. Please feel free to reopen if this still happens.