Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE] external_id for databricks_user with force=true isn't set #1097

Closed
pietern opened this issue Feb 9, 2022 · 1 comment · Fixed by #1102
Closed

[ISSUE] external_id for databricks_user with force=true isn't set #1097

pietern opened this issue Feb 9, 2022 · 1 comment · Fixed by #1102
Milestone

Comments

@pietern
Copy link
Contributor

pietern commented Feb 9, 2022

Configuration

resource "databricks_user" "foo" {
  user_name = "foo@bar.com"
  force     = true
}

Expected Behavior

Upon apply, the pre-existing user is imported into TF state, and running apply again doesn't show state skew.

Actual Behavior

The next apply shows state skew showing that the external_id property should be set to null.

When applied, this doesn't happen. I suspect external_id must be set as computed, or must be imported if is isn't set.

Terraform and provider versions

0.4.7

@nfx
Copy link
Contributor

nfx commented Feb 9, 2022

@pietern try adding tf:"suppress_diff" tag on external_id field. should help. slack me if it doesn't.

@nfx nfx added this to the v0.4.9 milestone Feb 11, 2022
nfx added a commit that referenced this issue Feb 11, 2022
@nfx nfx closed this as completed in #1102 Feb 11, 2022
nfx added a commit that referenced this issue Feb 11, 2022
nfx added a commit that referenced this issue Feb 11, 2022
# Version changelog

## 0.4.9

* Prevent creation of `databricks_group` with `users` and `admins` reserved names ([#1089](#1089)).
* Added support for shared clusters in multi-task `databricks_job` ([#1082](#1082)).
* Added diff suppression for `external_id` in `databricks_group` ([#1099](#1099)).
* Added diff suppression for `external_id` in `databricks_user` ([#1097](#1097)).
* Added `users`, `service_principals`, and `child_groups` exported properties to `databricks_group` data resource ([#1085](#1085)).
* Added various documentation improvements.
@nfx nfx mentioned this issue Feb 11, 2022
nfx added a commit that referenced this issue Feb 11, 2022
* Release v0.4.9

# Version changelog

## 0.4.9

* Prevent creation of `databricks_group` with `users` and `admins` reserved names ([#1089](#1089)).
* Added support for shared clusters in multi-task `databricks_job` ([#1082](#1082)).
* Added diff suppression for `external_id` in `databricks_group` ([#1099](#1099)).
* Added diff suppression for `external_id` in `databricks_user` ([#1097](#1097)).
* Added `users`, `service_principals`, and `child_groups` exported properties to `databricks_group` data resource ([#1085](#1085)).
* Added various documentation improvements.
michael-berk pushed a commit to michael-berk/terraform-provider-databricks that referenced this issue Feb 15, 2023
michael-berk pushed a commit to michael-berk/terraform-provider-databricks that referenced this issue Feb 15, 2023
* Release v0.4.9

# Version changelog

## 0.4.9

* Prevent creation of `databricks_group` with `users` and `admins` reserved names ([databricks#1089](databricks#1089)).
* Added support for shared clusters in multi-task `databricks_job` ([databricks#1082](databricks#1082)).
* Added diff suppression for `external_id` in `databricks_group` ([databricks#1099](databricks#1099)).
* Added diff suppression for `external_id` in `databricks_user` ([databricks#1097](databricks#1097)).
* Added `users`, `service_principals`, and `child_groups` exported properties to `databricks_group` data resource ([databricks#1085](databricks#1085)).
* Added various documentation improvements.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants