Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove validation for SPN resource for application_id on Azure #1171

Merged
merged 1 commit into from
Mar 10, 2022

Conversation

nfx
Copy link
Contributor

@nfx nfx commented Mar 10, 2022

Remove client-side validation in databricks_service_principal for application_id, that may not always be available in the planning stage.

Fixes #1165

Remove client-side validation in `databricks_service_principal` for `application_id`, that may not always be available in the planning stage.

Fixes #1165
@nfx nfx requested a review from alexott March 10, 2022 11:37
@codecov
Copy link

codecov bot commented Mar 10, 2022

Codecov Report

Merging #1171 (40a037d) into master (21c4f06) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1171      +/-   ##
==========================================
- Coverage   90.82%   90.82%   -0.01%     
==========================================
  Files         117      117              
  Lines        9741     9739       -2     
==========================================
- Hits         8847     8845       -2     
  Misses        528      528              
  Partials      366      366              
Impacted Files Coverage Δ
scim/resource_service_principal.go 94.44% <0.00%> (-0.16%) ⬇️

@nfx nfx merged commit 8c0a19e into master Mar 10, 2022
@nfx nfx deleted the issue/1165 branch March 10, 2022 11:53
michael-berk pushed a commit to michael-berk/terraform-provider-databricks that referenced this pull request Feb 15, 2023
…abricks#1171)

Remove client-side validation in `databricks_service_principal` for `application_id`, that may not always be available in the planning stage.

Fixes databricks#1165
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ISSUE] databricks_service_principal not accepting a "known after apply" application_id
2 participants