Ignore new lint error & update formatting #1292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1292 +/- ##
=======================================
Coverage 90.57% 90.57%
=======================================
Files 118 118
Lines 9970 9970
=======================================
Hits 9030 9030
Misses 559 559
Partials 381 381
|
nfx
reviewed
May 3, 2022
go.mod
Outdated
| @@ -19,6 +19,7 @@ require ( | |||
| github.com/zclconf/go-cty v1.10.0 | |||
| golang.org/x/mod v0.5.1 | |||
| golang.org/x/oauth2 v0.0.0-20220411215720-9780585627b5 | |||
| golang.org/x/text v0.3.7 | |||
There was a problem hiding this comment.
why do we need it? What license does it have?
There was a problem hiding this comment.
It's needed to fix error reported by linter, as strings.Title may not handle unicode correctly.
License is the same as for Go (https://cs.opensource.google/go/x/text/+/master:LICENSE, https://go.dev/LICENSE )
There was a problem hiding this comment.
can we add ignore to that rule in those two places and not add more third-party dependencies? =)
I'd park this till more holistic go1.18 update.
There was a problem hiding this comment.
ok.
it's really not a 3rd party, just "extension pack" from Golang devs...
There was a problem hiding this comment.
@nfx added ignore instead of using new library
nfx
approved these changes
May 3, 2022
alexott
changed the title
Lint error on Go 1.18: ``` provider/generate_test.go:250:18: strings.Title has been deprecated since Go 1.18 and an alternative has been available since Go 1.0: The rule Title uses for word boundaries does not handle Unicode punctuation properly. Use golang.org/x/text/cases instead. (SA1019) qa/testing.go:458:17: strings.Title has been deprecated since Go 1.18 and an alternative has been available since Go 1.0: The rule Title uses for word boundaries does not handle Unicode punctuation properly. Use golang.org/x/text/cases instead. (SA1019) ```
Merged
michael-berk
pushed a commit
to michael-berk/terraform-provider-databricks
that referenced
this pull request
Feb 15, 2023
Lint error on Go 1.18: ``` provider/generate_test.go:250:18: strings.Title has been deprecated since Go 1.18 and an alternative has been available since Go 1.0: The rule Title uses for word boundaries does not handle Unicode punctuation properly. Use golang.org/x/text/cases instead. (SA1019) qa/testing.go:458:17: strings.Title has been deprecated since Go 1.18 and an alternative has been available since Go 1.0: The rule Title uses for word boundaries does not handle Unicode punctuation properly. Use golang.org/x/text/cases instead. (SA1019) ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lint error on Go 1.18: